Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v24.1.0-IOFreeze #5094

Merged
merged 78 commits into from
Mar 8, 2024
Merged

Update to v24.1.0-IOFreeze #5094

merged 78 commits into from
Mar 8, 2024

Conversation

joseph-robertson
Copy link
Collaborator

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Feb 22, 2024
joseph-robertson and others added 23 commits March 7, 2024 10:06
…sCurves` to opt-in to set the default table lookups
…the table object in RT (note: object isn't FT'ed so no op there)
v24.1.0-IOFreeze: HeatExchangerAirToAirSensibleAndLatent
v24.1.0-IOFreeze: No Load Supply Air Flow Rate Control Set To Low Speed
v24.1.0-IOFreeze: PeopleDefinition's EnclosureAveraged key
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Mar 8, 2024

@jmarrec jmarrec marked this pull request as ready for review March 8, 2024 14:34
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 8, 2024

Tests are ok. merging. Thanks @joseph-robertson !

@jmarrec jmarrec merged commit 7979d37 into develop Mar 8, 2024
2 of 6 checks passed
@jmarrec jmarrec deleted the v24.1.0-IOFreeze branch March 8, 2024 15:36
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 8, 2024

Ideally we'll need to build E+ for Centos and update the hash, but I don't have the machine I use to build the centos package right now. It's not a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to EnergyPlus 24.1.0
3 participants