Interior windows missing required Outside Boundary Condition Object when ModelMerger #5153
Labels
Triage
Issue needs to be assessed and labeled, further information on reported might be needed
Issue overview
Originally reported as an issue with FloorspaceJS translator at #4670
@manuvarkey found the issue actually occurs in ModelMerger
Current Behavior
Adjacent Surfaces are matched after cloning in ModelMerger but adjacent SubSurfaces are not
Expected Behavior
Adjacent surfaces and SubSurfaces are matched after cloning in ModelMerger
Steps to Reproduce
Possible Solution
On going through the code for OpenStudio/src/model/ModelMerger.cpp, the following code segment was found dealing with setting adjacentSurface for Surface elements.
https://github.com/NREL/OpenStudio/blob/d2f0bdd21a70e6a9711f6da8f5aabecadc4a1a1c/src/model/ModelMerger.cpp#L349C1-L359C6
Best solution would be to implement a mergeSurface method that tracks the handles of sub surfaces too.
Details
Environment
Some additional details about your environment for this issue (if relevant):
Context
Incorrect simulation results
The text was updated successfully, but these errors were encountered: