Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4361 #4424

Merged
merged 19 commits into from
Nov 19, 2021
Merged

Issue 4361 #4424

merged 19 commits into from
Nov 19, 2021

Commits on Aug 27, 2021

  1. Added SubSurface::totalArea to get the area of a sub surface that inc… 

    …ludes the area of the frame. Modified PlanarSurface::netArea to call the SubSurface::totalArea. Added a unit test Issue_4361 to SubSurface_Gtest
    @ggartside
    ggartside committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a473f66 View commit details
    Browse the repository at this point in the history

  2. Modified windowToWallRatio to call SubSurface totalArea. Modified tes… 

    …t to include window wall ratio check
    @ggartside
    ggartside committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    93891ef View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Renamed totalArea to roughOpeningArea 

    Added method totalAreaOfSubSurfaces to Surface
Added polygonInPolygon methof to intersection
    @ggartside
    ggartside committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    1e54ead View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Corrected some clang-format issues (this thing is picky!)

    @ggartside
    ggartside committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    7fd01f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Update src/model/SubSurface.hpp 

    Co-authored-by: Dan Macumber <dan.macumber@gmail.com>
    @ggartside @macumber
    ggartside and macumber committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    2faa5b3 View commit details
    Browse the repository at this point in the history

  2. Update src/model/SubSurface.hpp 

    Co-authored-by: Dan Macumber <dan.macumber@gmail.com>
    @ggartside @macumber
    ggartside and macumber committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    0cf9f62 View commit details
    Browse the repository at this point in the history

  3. Includes sub surface multiplier when caclulating the rough opening ar… 

    …ea for the window wall ratio calculartion
    @ggartside
    ggartside committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    5d3f7d8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue-4361' of https://github.com/NREL/OpenStudio into … 

    …issue-4361
    @ggartside
    ggartside committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    6c6c709 View commit details
    Browse the repository at this point in the history

  5. I took the code change suggestions but didnt realise if the method na… 

    …me was chanegd in the header utomatically it wouldnt change all references
    @ggartside
    ggartside committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    1e5bfa4 View commit details
    Browse the repository at this point in the history

  6. Fix building issue on macOS, linux

    @ggartside
    ggartside committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    da8da67 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Merge branch 'develop' into issue-4361

    @tijcolem
    tijcolem committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    3d95397 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. remove .patch files

    @tijcolem
    tijcolem committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    65829f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Merge branch 'develop' into issue-4361

    @tijcolem
    tijcolem committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1be5113 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Merge branch 'develop' into issue-4361

    @jmarrec
    jmarrec committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    f731bed View commit details
    Browse the repository at this point in the history

  2. Move tests to model/test instead of EnergyPlus/Test

    @jmarrec
    jmarrec committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    6a0322c View commit details
    Browse the repository at this point in the history

  3. Apply Nitpicking changes in review

    @jmarrec
    jmarrec committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    16678b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Code review changes

    @ggartside
    ggartside committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    82f7472 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Added frameArea and dividerArea as suggested

    @ggartside
    ggartside committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    dda263b View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Modified test that checks frame and divider areas

    @ggartside
    ggartside committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    155a734 View commit details
    Browse the repository at this point in the history