Issue 4375 gbxml

[ggartside]

Pull request overview

• Fixes GBXML Import reverses floors/ceilings normals and surface types  #4375

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ggartside]

The test was failing because my test file had become corrupted somehow, and I hadn't added it to the CMakeLists.txt file which I have now done so fingers crossed!

[ci-commercialbuildings]

CI Results for 46721d8:

• Ubuntu 18.04:

  • OpenStudio-3.3.1-alpha+46721d8da5-Ubuntu-18.04.deb
  • OpenStudio-3.3.1-alpha+46721d8da5-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.3.1-alpha+46721d8da5-Ubuntu-20.04.deb
  • OpenStudio-3.3.1-alpha+46721d8da5-Ubuntu-20.04.tar.gz
  • perf_all.csv
  • perf_comparison.png
  • perf_means.csv

• Darwin:

  • OpenStudio-3.3.1-alpha+46721d8da5-Darwin.dmg
  • OpenStudio-3.3.1-alpha+46721d8da5-Darwin.tar.gz

• Windows:

  • OpenStudio-3.3.1-alpha+46721d8da5-Windows.exe
  • OpenStudio-3.3.1-alpha+46721d8da5-Windows.tar.gz

• Code Coverage:

  • OpenStudio-46721d8da5a44f03bc8840eb875369c0a45ea27a.gcov.html