Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4490 - Expose RoofGeometry helpers to Swig bindings #4491

Merged
merged 1 commit into from Nov 12, 2021

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Nov 4, 2021

Pull request overview

Pull Request Author

  • SWIG interface file changed
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added severity - Minor Bug Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Ruby bindings component - Python bindings labels Nov 4, 2021
@jmarrec jmarrec requested a review from tijcolem November 4, 2021 09:32
@jmarrec jmarrec self-assigned this Nov 4, 2021
@tijcolem tijcolem merged commit db1d522 into develop Nov 12, 2021
@tijcolem tijcolem deleted the 4490_RoofGeometry_Bindings branch November 12, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Python bindings component - Ruby bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Minor Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoofGeometry helpers aren't exposed to SWIG bindings
3 participants