Addresses #4469, method to Translate ScheduleYear/ScheduleWeek to ScheduleRuleset

[joseph-robertson]

Pull request overview

• Fixes Method to Translate ScheduleYear/ScheduleWeek to ScheduleRuleset #4469

Replace Schedule:Year to Schedule:Year RT with Schedule:Year to Schedule:Ruleset.

Issues:

• Schedule:Week:Daily to Schedule:Week RT is performed directly from ReverseTranslator.cpp (i.e., independent of Schedule:Year to Schedule:Ruleset
• Ctor for Schedule:Rule when passing in a daySchedule automatically clones and sets the daySchedule (why?)
• Ctor for Schedule:Ruleset automatically creates a defaultDaySchedule; not sure how we'd parse defaultDaySchedule from the idf, but even if we could we'd have to transfer its values to ruleset's defaultDaySchedule as there is no setter for this object (should there be? or perhaps even a Schedule:Ruleset ctor that passes one in?)
• The summer/winter design day, holiday, and custom day 1/2 schedules are specific to each Schedule:Ruleset whereas in the IDF they are defined for each Schedule:Week:Daily; what happens if these schedules vary between weeks? Create more ruleset objects? Only support non varying schedules and switch to Schedule:Year RT if they vary?
• Setting summer/winter, holiday, and custom day 1/2 schedules clones the schedule passed in and sets the clone (why?)

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for 37dd893:

• Ubuntu 18.04:

  • OpenStudio-3.3.1-alpha+37dd893cc1-Ubuntu-18.04.deb
  • OpenStudio-3.3.1-alpha+37dd893cc1-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.3.1-alpha+37dd893cc1-Ubuntu-20.04.deb
  • OpenStudio-3.3.1-alpha+37dd893cc1-Ubuntu-20.04.tar.gz
  • perf_all.csv
  • perf_comparison.png
  • perf_means.csv

• Darwin:

  • OpenStudio-3.3.1-alpha+37dd893cc1-Darwin.dmg
  • OpenStudio-3.3.1-alpha+37dd893cc1-Darwin.tar.gz

• Windows:

• Code Coverage: