Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openstudio-gems, conan-openstudio-ruby and add support for Apple M1 #4518

Merged
merged 9 commits into from Jan 19, 2022

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jan 18, 2022

Pull request overview

My local M1 built works, all test passing

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added Enhancement Request Developer Issue component - Conan Dependency / Package manager problems labels Jan 18, 2022
@jmarrec jmarrec requested a review from tijcolem January 18, 2022 23:21
@jmarrec jmarrec self-assigned this Jan 18, 2022
@tijcolem
Copy link
Collaborator

tijcolem commented Jan 18, 2022

Launched a full build of this before labeling "Pull Request Ready for CI". May need to launch another with clean conan cache but let's see how this goes first. https://ci.commercialbuildings.dev/blue/organizations/jenkins/openstudio-develop-nightly/detail/openstudio-develop-nightly/1378/pipeline

@tijcolem
Copy link
Collaborator

This is passed using the full build so this is good to go.

@tijcolem tijcolem merged commit 441b14f into develop Jan 19, 2022
@tijcolem tijcolem deleted the apple_m1_arm64 branch January 19, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants