Addresses #4531, breaking changes

[joseph-robertson]

Pull request overview

• Addresses Breaking changes to consider #4531:
• CoolingTower:*Speed
  • evaporationLossMode (boost::optional<std::string> to std::string)
  • blowdownCalculationMode (boost::optional<std::string> to std::string)
  • cellControl for CoolingTower:VariableSpeed
• PlantLoop
  • commonPipeSimulation (boost::optional<std::string> to std::string)
  • isCommonPipeSimulationDefaulted
  • add commonPipeSimulationValues getter
  • add validCommonPipeSimulationValues getter

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

No problem with these changes. I'd like a quick one or two line tests for the PlantLoop method probably.
And I will run a full OpenStudio-Resources test suite to check whether we need API version switches over there.

[jmarrec]

OS-resources run at https://github.com/NREL/OpenStudio-resources/runs/5540792038?check_suite_focus=true (in progress)

[jmarrec]

OS-resources run is clean, no new failures.

[ci-commercialbuildings]

CI Results for 591f144:

• Ubuntu 18.04:

• Ubuntu 20.04:

  • OpenStudio-3.4.0-alpha+591f1443d5-Ubuntu-20.04.deb
  • OpenStudio-3.4.0-alpha+591f1443d5-Ubuntu-20.04.tar.gz
  • perf_all.csv
  • perf_comparison.png
  • perf_means.csv

• Darwin:

  • OpenStudio-3.4.0-alpha+591f1443d5-Darwin.dmg
  • OpenStudio-3.4.0-alpha+591f1443d5-Darwin.tar.gz

• Windows:

  • OpenStudio-3.4.0-alpha+591f1443d5-Windows.exe
  • OpenStudio-3.4.0-alpha+591f1443d5-Windows.tar.gz