Fix#127 - Fix volume calculation to match EnergyPlus

[jmarrec]

Pull request overview

• Fixes Fix volume calculation to match EnergyPlus (Bugzilla #730) #127
• Add a Polyhedron class in utilities/geometry, which reimplements the same logic that E+ does, with two main methods:
  • isEnclosedVolume() which check that each edge/segment is used twice exactly, potentially splitting up existing edges (this is similar to what intersectSurfaces would do, but does not reuse that portion)
  • calcPolyhedronVolume, which assuming your volume is indeed enclosed, will return the appropriate volume.

Space::volume is enhanced to do:

• If isEnclosedVolume() => calcPolyhedronVolume
• Otherwise, keep existing behavior (which is take an average of the floor and ceiling heights, multiply by floor area)
  • E+ in fact has a few more potential alternatives, by checking if a floor and ceiling are the same surface or not, if walls are vertical etc. I did not seem it terribly important to also implements those, as the goal here is more to correctly calculate enclosed volumes (volumes are meant to be enclosed really)

Pull Request Author

• Model API Changes / Additions
• Model API methods are tested (in src/model/test)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

the windows build error makes no sense.

Unable to open file D:\jenkins\openstudio\develop\build\src\utilities\csharp_OpenStudioUtilitiesData_wrap.cxx: Permission denied

[ci-commercialbuildings]

CI Results for 47d37aa:

• Ubuntu 18.04:

  • OpenStudio-3.4.1-alpha+47d37aa488-Ubuntu-18.04.deb
  • OpenStudio-3.4.1-alpha+47d37aa488-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.4.1-alpha+c48c777c9c-Ubuntu-20.04.deb
  • OpenStudio-3.4.1-alpha+c48c777c9c-Ubuntu-20.04.tar.gz
  • perf_all.csv
  • perf_comparison.png
  • perf_means.csv

• Darwin:

  • OpenStudio-3.4.1-alpha+47d37aa488-Darwin-x86_64.dmg
  • OpenStudio-3.4.1-alpha+47d37aa488-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.4.1-alpha+afe4d3cc8c-Windows.exe
  • OpenStudio-3.4.1-alpha+afe4d3cc8c-Windows.tar.gz

• Code Coverage:

[tijcolem]

This is great to have this issue resolved! many years.