Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix GLTF extras broke running tests in Debug #4597

Merged
merged 1 commit into from
May 24, 2022

Commits on May 24, 2022

  1. GLTF extras broke running ctest in Debug (400 tests segfaulting)

    This is an absolute minimal fix to have the tests passing, but I think we should refactor: 
    * avoid all static storage objects
    * change the data layout and API in the classes that are in GltfForwardTranslator
        * just use `T` (eg double) instead of std::tuple<std::string, tinygltf::Value(T)> 
        * provide a protected toGltfValue that will create the std::map<std::string, tinygltf::Value>
    * Move those to separate files (like the wrappers are)
    * Remove the wrappers (which are superflous now)The wrappers classes and superfluous, there's a lot of static storage objects throughout that should be deleting.
    The data layouts of the classes in GltfForwardTranslator makes little sense to me (using a tuple<string, T> makes little sense to me).
    cf #4571
    jmarrec committed May 24, 2022
    Configuration menu
    Copy the full SHA
    f32a6a1 View commit details
    Browse the repository at this point in the history