Addresses #4538, wrap phase change material properties

[joseph-robertson]

Pull request overview

• Fixes Wrap phase change material properties #4538
• Questions:
  • MaterialProperty:PhaseChange
    • Is at least one temperature-enthalpy extensible object required? (Based on the os-resources test, are at least 3 required?)
    • If some temperature-enthalpy pairs are required, do we need to pass them into the ctor? Update: I created a second ctor that takes temperature-enthalpy pairs as an argument, but there is no minimum on the number of the pairs.
  • MaterialProperty:PhaseChangeHysteresis
  • Reverse translators? There currently isn't one for MaterialPropertyMoisturePenetrationDepthSettings.

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Addresses #4538, wrap phase change material properties OpenStudio-resources#168
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

Jumping in unannounced because I saw swig build error. I didn't do a full review since this is still marked as a draft.

[joseph-robertson]

@jmarrec I responded to most of your comments. What (optionally?) remains:

• bool initializeTemperatureEnthalpyWithDefaults in MaterialPropertyPhaseChange ctor
• temperatureEnthalpyIndex and getTemperatureEnthalpy (you sound a little torn on this one)

[jmarrec]

Suggested an IDD change (which we should probably propose to E+ on the issue board too), otherwise I think it's ready to drop! Thanks for the new objects @joseph-robertson !

[ci-commercialbuildings]

CI Results for e9677bc:

• Ubuntu 18.04:

  • OpenStudio-3.4.1-alpha+e9677bc77b-Ubuntu-18.04.deb
  • OpenStudio-3.4.1-alpha+e9677bc77b-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.4.1-alpha+e9677bc77b-Ubuntu-20.04.deb
  • OpenStudio-3.4.1-alpha+e9677bc77b-Ubuntu-20.04.tar.gz
  • perf_all.csv
  • perf_comparison.png
  • perf_means.csv

• Darwin:

  • OpenStudio-3.4.1-alpha+e9677bc77b-Darwin-x86_64.dmg
  • OpenStudio-3.4.1-alpha+e9677bc77b-Darwin-x86_64.tar.gz

• Windows:

• Code Coverage: