New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ubuntu 18.04 and Centos7 #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), to avoid rebuilding openstudio_ruby
…ll packages from my docker
… package on CentOS to /usr/local/openstudio-3.4.0/bin/openstudio instead of /usr/bin/openstudio
….0 and openssl/1.1.1o like we do I patched websocketpp here: conan-io/conan-center-index#11334
…hat uses the same openssl 1.1.1o version we use cf NREL/conan-openstudio-ruby#43
jmarrec
added
the
Pull Request - Ready for CI
This pull request if finalized and is ready for continuous integration verification prior to merge.
label
Jun 23, 2022
Temporary changes I made to the ubuntu 18.04 jenkins file.
|
CI Results for fe30b8a:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer Issue
Pull Request - Ready for CI
This pull request if finalized and is ready for continuous integration verification prior to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Use a new revision of websocketpp and cpprestsdk that uses boost/1.79.0 and openssl/1.1.1o like we do
Allow passing a
CONAN_FIRST_TIME_BUILD_ALL:BOOL=ON
flag to force build everything on the first pass... that way all the libraries are built with the same GLIBC and we don't have undefined symbols.Lots of patching on the conan side too:
For CentOS, a configurable docker exists at https://github.com/jmarrec/docker-OpenStudio-CentOS
I'm going to be replaying the Ubuntu 18.04 run with a modified jenkins file so I pass that conan flag. I opened a PR to https://github.com/NREL/cbci_jenkins_libs/pull/95 so we can later trigger that same cleanup and full rebuild just via passing
[force-clean]
in a commit messagePull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.