Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ubuntu 18.04 and Centos7 #4614

Merged
merged 16 commits into from Jun 23, 2022
Merged

Support Ubuntu 18.04 and Centos7 #4614

merged 16 commits into from Jun 23, 2022

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 23, 2022

Pull request overview

I'm going to be replaying the Ubuntu 18.04 run with a modified jenkins file so I pass that conan flag. I opened a PR to https://github.com/NREL/cbci_jenkins_libs/pull/95 so we can later trigger that same cleanup and full rebuild just via passing [force-clean] in a commit message

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec requested a review from tijcolem June 23, 2022 11:00
@jmarrec jmarrec self-assigned this Jun 23, 2022
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Jun 23, 2022
@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 23, 2022

Temporary changes I made to the ubuntu 18.04 jenkins file.

https://github.com/NREL/cbci_jenkins_libs/blob/335a26a97184221b3acbb47b3d4ebe2b33025b43/vars/openstudio_incremental_develop_ubuntu_1804.groovy#L137-L152

      stage("temporary cleanup") {
        dir("${linux_base_build}") {
          deleteDir();
        }
        sh("/bin/rm -Rf ~/.conan/data");
        sh("conan profile show default");
        sh("gcc --version");
        sh("conan profile update settings.compiler.version=`gcc -dumpversion` default");
        sh("conan profile show default");
      }

https://github.com/NREL/cbci_jenkins_libs/blob/335a26a97184221b3acbb47b3d4ebe2b33025b43/vars/openstudio_incremental_develop_ubuntu_1804.groovy#L210

sh("cmake -DCONAN_FIRST_TIME_BUILD_ALL:BOOL=ON -DBUILD_TESTING=ON [...]);

@jmarrec jmarrec merged commit 52674ca into develop Jun 23, 2022
@jmarrec jmarrec deleted the CentOS branch June 23, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants