Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4551 - Add minimum/maximum values to numeric OSArguments and use it in validateUserArgument #4621

Merged
merged 6 commits into from
Aug 12, 2022
Merged

#4551 - Add minimum/maximum values to numeric OSArguments and use it in validateUserArgument #4621

merged 6 commits into from
Aug 12, 2022
+218 −88

Commits on Jun 29, 2022

  1. Modernize measure_manager by using the OpenStudio::Measure namespace … 

    …instead of the deprecated Ruleset one
    @jmarrec
    jmarrec committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    69e0c68 View commit details
    Browse the repository at this point in the history

  2. cf #4551 - capture domain for int/double OSArguments

    @jmarrec
    jmarrec committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    a66b516 View commit details
    Browse the repository at this point in the history

  3. (+ use fmt::format instead of stringstream where not needed)

    @jmarrec
    jmarrec committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    9f5f23f View commit details
    Browse the repository at this point in the history

  4. Additional: fix todo: Pass domain from a measure to BCLMeasure: the m… 

    …in/max value now will show in measure.xml
    @jmarrec
    jmarrec committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    a6be9f6 View commit details
    Browse the repository at this point in the history

  5. Add a test for Double/Integer OSArgument domain validation

    @jmarrec
    jmarrec committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    e2d00da View commit details
    Browse the repository at this point in the history

  6. std::numeric_limits<T>::min() gives you the smallest positive value =… 

    … minimum finite value (2.2250738585072014e-308 not `- std::numeric_limits<T>::max()`
    @jmarrec
    jmarrec committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    058d347 View commit details
    Browse the repository at this point in the history