Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v22.2.0 #4658

Merged
merged 302 commits into from Sep 28, 2022
Merged

Update to v22.2.0 #4658

merged 302 commits into from Sep 28, 2022

Conversation

joseph-robertson
Copy link
Collaborator

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.5.0 milestone Aug 23, 2022
@joseph-robertson joseph-robertson self-assigned this Aug 23, 2022
@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Aug 24, 2022
@@ -381,7 +381,7 @@
! s
! V
! VA
! W/m2 or deg C
! W/m2, deg C or cd/m2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making IddFactory_Units throw. I'll fix the test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done e008d5f

joseph-robertson and others added 12 commits September 26, 2022 10:23
I bumped gfortran from 9 to 11 on E+ GHA runners, it must handle `-static` differently
Found via HPXML testing `openstudio run -w workflow/template-run-hpxml-with-stochastic-occupancy.osw`

When adding domain validation, I messed up the logic
Fix #4656 - E+ 22.2.0: Wrap Chiller:Electric:ASHRAE205
@jmarrec jmarrec changed the title Update to v22.2.0-IOFreeze Update to v22.2.0 Sep 28, 2022
@jmarrec jmarrec marked this pull request as ready for review September 28, 2022 06:50
… Air Fan Op Sched to always off to try and limit deviation
Volume, CeilingHeight, FloorArea for Space object, try 2
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 28, 2022

@joseph-robertson @tijcolem I fixed up a few things in the last commits and now tests should all be passing. Letting CI run on it, but if green let's merge to develop

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 28, 2022

I need to modify the ChillerElectricASHRAE205 tests to avoid them copying/deleting the same path/copied cbor file so they don't fail when run in parallel.

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 28, 2022

Not going to wait 4 hours for windows to come in. I'm merging this but I'll check on the windows runner later.

@jmarrec jmarrec merged commit 3ffe2f0 into develop Sep 28, 2022
@jmarrec jmarrec deleted the v22.2.0-IOFreeze branch September 28, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to EnergyPlus 22.2.0
3 participants