Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4675 - E+ 22.2.0 - Sizing:Zone has new fields #4677

Merged
merged 13 commits into from
Sep 20, 2022
Merged

Fix #4675 - E+ 22.2.0 - Sizing:Zone has new fields #4677

merged 13 commits into from
Sep 20, 2022

Commits on Sep 12, 2022

  1. Naive insert new fields in Sizing:Zone

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4a35503 View commit details
    Browse the repository at this point in the history

  2. whitespace

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ba392cc View commit details
    Browse the repository at this point in the history

  3. Make the Schedule fields \object-list (!)

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3045168 View commit details
    Browse the repository at this point in the history

  4. Implement new model fields

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    76553eb View commit details
    Browse the repository at this point in the history

  5. model Gtest for new fields

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    e604ed9 View commit details
    Browse the repository at this point in the history

  6. Add a full RT + extend FT test for Sizing:Zone

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    5c98531 View commit details
    Browse the repository at this point in the history

  7. Adjust RT and FT for new fields (+ several already missing fields in RT)

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ae172c5 View commit details
    Browse the repository at this point in the history

  8. The E+ Idd has the wrong type for the Sizing:Zone Dehum/hum schedules

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    912f001 View commit details
    Browse the repository at this point in the history

  9. Add a VT test for the new fields' insertion

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    5668a41 View commit details
    Browse the repository at this point in the history

  10. Write VT

    @jmarrec
    jmarrec committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4d5a2e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Merge branch 'v22.2.0-IOFreeze' 

    Conflicts:
	src/osversion/VersionTranslator.cpp
	src/osversion/test/VersionTranslator_GTest.cpp
    @jmarrec
    jmarrec committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    7ee3189 View commit details
    Browse the repository at this point in the history

  2. Sizing:Zone new fields: Make fields with a default \required-field 

    E+ doesn't provide a default for `Zone Dehumidification Design Supply Air Humidity Ratio` and I really don't have a good default either, so leaving this as optional
    @jmarrec
    jmarrec committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    f5eccf0 View commit details
    Browse the repository at this point in the history

  3. Missed a couple in RT test

    @jmarrec
    jmarrec committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    ef4ad08 View commit details
    Browse the repository at this point in the history