Fix #4761 - Cleanup temporary directory when doing *Schematron* XMLValidation #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
severity - Minor Bug
component - Utilities Other
Pull Request - Ready for CI
jmarrec
commented
Dec 10, 2022
Comment on lines
+167
to
+168
| // #4761 - XMLValidator's dtor should clean up the tmpDir | ||
| EXPECT_FALSE(openstudio::filesystem::exists(tmpDir)) << "Expected tmpDir to be deleted: " << tmpDir; |
There was a problem hiding this comment.
Fails before fix, works after
| const auto tmpDir = openstudio::filesystem::create_temporary_directory("xmlvalidation"); | ||
| if (tmpDir.empty()) { | ||
| LOG_AND_THROW(fmt::format("Failed to create a temporary directory for extracting the stylesheets need to transform the Schematron '{}'", | ||
| m_tempDir = openstudio::filesystem::create_temporary_directory("xmlvalidation"); |
There was a problem hiding this comment.
store the temp dir
Comment on lines
+215
to
+224
| XMLValidator::~XMLValidator() { | ||
| if (m_tempDir) { | ||
| try { | ||
| const auto count = openstudio::filesystem::remove_all(m_tempDir.get()); | ||
| logAndStore(Debug, fmt::format("Removed temporary directory with {} files", count)); | ||
| } catch (const std::exception& e) { | ||
| logAndStore(Warn, fmt::format("Error removing temporary directory at {}, Description: {}", toString(m_tempDir.get()), e.what())); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Delete temp Dir in dtor
Comment on lines
+71
to
+75
| ~XMLValidator(); | ||
| XMLValidator(const XMLValidator& other) = default; | ||
| XMLValidator(XMLValidator&& other) noexcept = default; | ||
| XMLValidator& operator=(const XMLValidator& other) = default; | ||
| XMLValidator& operator=(XMLValidator&& other) noexcept = default; |
|
CI Results for c488e51:
|
tijcolem
approved these changes
Dec 13, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.