CSharp fixes #4893
CSharp fixes #4893
Conversation
.github/workflows/buildCSharp.yml
Outdated
| with: | ||
| ref: master |
| add_library(csharp_warnings INTERFACE) | ||
| target_compile_options(csharp_warnings INTERFACE "$<${is_msvc_genex}:/wd4996>") | ||
| target_compile_options(csharp_warnings INTERFACE "$<${is_msvc_genex}:/bigobj>") | ||
| target_compile_options(csharp_warnings INTERFACE "$<${is_gnu_or_clang_genex}:-Wno-deprecated-declarations>") | ||
| target_compile_options(csharp_warnings INTERFACE "$<${is_gnu_or_clang_genex}:-Wno-unused-function>") |
There was a problem hiding this comment.
What?! Modern Cmake?! Yep!
There was a problem hiding this comment.
Anyways, the only new flag is -Wno-unused-function. But I'm using an interface library to avoid polluting the global namespace via add_definitions
| PRIVATE | ||
| openstudiolib | ||
| csharp_warnings |
There was a problem hiding this comment.
And linking to that interface lib. And making the linkage PRIVATE for openstudiolib, another modern cmake practice which we already have in some places
| PRIVATE | ||
| openstudiolib | ||
| csharp_warnings |
There was a problem hiding this comment.
and again for the rest of the csharp libs
|
Dammmmmm I'm so dumb! I couldn't understand why the CMakeLists.txt changes fixed the build on my machine but not on Github Actions... I'm specifically building branch |
|
Ok, the 3.6.1 CSharp bindings can be found on https://github.com/NREL/OpenStudio/actions/runs/5077752228 @tijcolem can you upload them to https://www.nuget.org/packages/OpenStudio please? @MingboPeng FYI, if you want to reupload the platform specific one |
…g patched csharp/CMakeLists.txt" This reverts commit 70cf714.
Pull request overview
Fix 3.6.1 Csharp workflow that failed due to a Wunused-function warning. (likely because of updated compiler or something)
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.