Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AirLoopHVACUnitarySystem set Method During XXX Operation - option #4905

Merged
merged 18 commits into from
Jul 14, 2023
Merged

AirLoopHVACUnitarySystem set Method During XXX Operation - option #4905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9405db6
Cleanup the DuringCooling API. One break, the return of supplyAirFlow…
jmarrec Jun 1, 2023
5d93c8d
Merge branch 'airloop-hvac-unitary-sys-opmethod' into airloop-hvac-un…
joseph-robertson Jun 14, 2023
3728488
Merge branch 'airloop-hvac-unitary-sys-opmethod' into airloop-hvac-un…
joseph-robertson Jul 12, 2023
08858b4
Add None default to idd.
joseph-robertson Jul 12, 2023
fa7543a
Simplify method getter after introducing None default.
joseph-robertson Jul 12, 2023
af26872
Merge pull request #4927 from NREL/airloop-hvac-unitary-sys-opmethod3
jmarrec Jul 13, 2023
d3d1f3d
Add None default for HeatingOperation.
joseph-robertson Jul 13, 2023
b54af03
Updates for new os_deprecated method args.
joseph-robertson Jul 13, 2023
dd0bd1a
Update ft for heating.
joseph-robertson Jul 13, 2023
01ee57b
Update all heating methods.
joseph-robertson Jul 13, 2023
da09bd9
Formatting.
joseph-robertson Jul 13, 2023
79b6ca3
Clean up minor typos.
joseph-robertson Jul 13, 2023
57d142d
More case typos.
joseph-robertson Jul 13, 2023
fd3d025
Update model tests.
joseph-robertson Jul 13, 2023
1413329
More case typos.
joseph-robertson Jul 13, 2023
2cef40d
Stub deprecated_at_msg in cpp.
joseph-robertson Jul 13, 2023
df44eab
Update deprecated messages.
joseph-robertson Jul 14, 2023
36a9a7d
Include deprecatedhelpers hpp.
joseph-robertson Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions resources/model/OpenStudio.idd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11902,6 +11902,7 @@ OS:AirLoopHVAC:UnitarySystem,
\key FlowPerFloorArea
\key FractionOfAutosizedCoolingValue
\key FlowPerCoolingCapacity
\default None
\note Enter the method used to determine the cooling supply air volume flow rate.
\note None is used when a cooling coil is not included in the unitary system or this field may be blank.
\note SupplyAirFlowRate is selected when the magnitude of the supply air volume is used.
Expand Down Expand Up @@ -11946,6 +11947,7 @@ OS:AirLoopHVAC:UnitarySystem,
\key FlowPerFloorArea
\key FractionOfAutosizedHeatingValue
\key FlowPerHeatingCapacity
\default None
\note Enter the method used to determine the heating supply air volume flow rate.
\note None is used when a heating coil is not included in the unitary system or this field may be blank.
\note SupplyAirFlowRate is selected when the magnitude of the supply air volume is used.
Expand Down
118 changes: 56 additions & 62 deletions src/energyplus/ForwardTranslator/ForwardTranslateAirLoopHVACUnitarySystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,34 @@ namespace energyplus {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingCoilObjectType, _heatingCoil->iddObject().name());
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingCoilName, _heatingCoil->name().get());
}

// Supply Air Flow Rate Method During Heating Operation
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRateMethod,
modelObject.supplyAirFlowRateMethodDuringHeatingOperation());

// Supply Air Flow Rate During Heating Operation
if (modelObject.isSupplyAirFlowRateDuringHeatingOperationAutosized()) {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRate, "Autosize");
} else if (auto val_ = modelObject.supplyAirFlowRateDuringHeatingOperation()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRate, val_.get());
}

// Supply Air Flow Rate Per Floor Area during Heating Operation
if (auto val_ = modelObject.supplyAirFlowRatePerFloorAreaduringHeatingOperation()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRatePerFloorArea, val_.get());
}

// Fraction of Autosized Design Heating Supply Air Flow Rate
if (auto val_ = modelObject.fractionofAutosizedDesignHeatingSupplyAirFlowRate()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingFractionofAutosizedHeatingSupplyAirFlowRate, val_.get());
}

// Design Supply Air Flow Rate Per Unit of Capacity During Heating Operation
if (auto val_ = modelObject.designSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRatePerUnitofCapacity, val_.get());
}
} else {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRateMethod, "None");
}

// DX Heating Coil Sizing Ratio
Expand All @@ -217,6 +245,34 @@ namespace energyplus {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingCoilObjectType, _coolingCoil->iddObject().name());
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingCoilName, _coolingCoil->name().get());
}

// Supply Air Flow Rate Method During Cooling Operation
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRateMethod,
modelObject.supplyAirFlowRateMethodDuringCoolingOperation());

// Supply Air Flow Rate During Cooling Operation
if (modelObject.isSupplyAirFlowRateDuringCoolingOperationAutosized()) {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRate, "Autosize");
} else if (auto val_ = modelObject.supplyAirFlowRateDuringCoolingOperation()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRate, val_.get());
}

// Supply Air Flow Rate Per Floor Area During Cooling Operation
if (auto val_ = modelObject.supplyAirFlowRatePerFloorAreaDuringCoolingOperation()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRatePerFloorArea, val_.get());
}

// Fraction of Autosized Design Cooling Supply Air Flow Rate
if (auto val_ = modelObject.fractionofAutosizedDesignCoolingSupplyAirFlowRate()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingFractionofAutosizedCoolingSupplyAirFlowRate, val_.get());
}

// Design Supply Air Flow Rate Per Unit of Capacity During Cooling Operation
if (auto val_ = modelObject.designSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation()) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRatePerUnitofCapacity, val_.get());
}
} else {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRateMethod, "None");
}

// Use DOAS DX Cooling Coil
Expand Down Expand Up @@ -252,68 +308,6 @@ namespace energyplus {
}
}

// Supply Air Flow Rate Method During Cooling Operation
s = modelObject.supplyAirFlowRateMethodDuringCoolingOperation();
if (s) {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRateMethod, s.get());
}

// Supply Air Flow Rate During Cooling Operation
if (modelObject.isSupplyAirFlowRateDuringCoolingOperationAutosized()) {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRate, "Autosize");
} else if ((d = modelObject.supplyAirFlowRateDuringCoolingOperation())) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRate, d.get());
}

// Supply Air Flow Rate Per Floor Area During Cooling Operation
d = modelObject.supplyAirFlowRatePerFloorAreaDuringCoolingOperation();
if (d) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRatePerFloorArea, d.get());
}

// Fraction of Autosized Design Cooling Supply Air Flow Rate
d = modelObject.fractionofAutosizedDesignCoolingSupplyAirFlowRate();
if (d) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingFractionofAutosizedCoolingSupplyAirFlowRate, d.get());
}

// Design Supply Air Flow Rate Per Unit of Capacity During Cooling Operation
d = modelObject.designSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation();
if (d) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::CoolingSupplyAirFlowRatePerUnitofCapacity, d.get());
}

// Supply Air Flow Rate Method During Heating Operation
s = modelObject.supplyAirFlowRateMethodDuringHeatingOperation();
if (s) {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRateMethod, s.get());
}

// Supply Air Flow Rate During Heating Operation
if (modelObject.isSupplyAirFlowRateDuringHeatingOperationAutosized()) {
unitarySystem.setString(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRate, "Autosize");
} else if ((d = modelObject.supplyAirFlowRateDuringHeatingOperation())) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRate, d.get());
}

// Supply Air Flow Rate Per Floor Area during Heating Operation
d = modelObject.supplyAirFlowRatePerFloorAreaduringHeatingOperation();
if (d) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRatePerFloorArea, d.get());
}

// Fraction of Autosized Design Heating Supply Air Flow Rate
d = modelObject.fractionofAutosizedDesignHeatingSupplyAirFlowRate();
if (d) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingFractionofAutosizedHeatingSupplyAirFlowRate, d.get());
}

// Design Supply Air Flow Rate Per Unit of Capacity During Heating Operation
d = modelObject.designSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation();
if (d) {
unitarySystem.setDouble(AirLoopHVAC_UnitarySystemFields::HeatingSupplyAirFlowRatePerUnitofCapacity, d.get());
}

// Supply Air Flow Rate Method When No Cooling or Heating is Required
s = modelObject.supplyAirFlowRateMethodWhenNoCoolingorHeatingisRequired();
if (s) {
Expand Down
Loading