Labs cli remove verbose in favor of --loglevel + minor swig adjustments
#4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstudio.Workflow() like in Ruby
jmarrec
added
component - CLI
Pull Request - Ready for CI
jmarrec
commented
Jun 30, 2023
Comment on lines
-103
to
-114
| auto* const verboseOpt = experimentalApp->add_flag_function( | ||
| "--verbose", | ||
| [](auto count) { | ||
| if (count == 1) { | ||
| fmt::print("Setting Log Level to Debug ({})\n", LogLevel::Debug); | ||
| openstudio::Logger::instance().standardOutLogger().setLogLevel(LogLevel::Debug); | ||
| } else if (count == 2) { | ||
| fmt::print("Setting Log Level to Trace ({})\n", LogLevel::Trace); | ||
| openstudio::Logger::instance().standardOutLogger().setLogLevel(LogLevel::Trace); | ||
| } | ||
| }, | ||
| "Print the full log to STDOUT - sets verbosity to Debug if given once and Trace if given twice."); |
There was a problem hiding this comment.
actual change is here
Comment on lines
+14
to
+19
| SWIGINTERN PyObject* SWIG_From_JsonValue(const Json::Value& value) { | ||
| // PyErr_WarnEx(PyExc_UserWarning, "Translating a Json::Value to a PyObject", 1); // Debugging | ||
|
|
||
| if (value.isNull()) { | ||
| return Py_None; | ||
| } |
Comment on lines
+75
to
+79
| SWIGINTERN VALUE SWIG_From_JsonValue(const Json::Value& value) { | ||
|
|
||
| if (value.isNull()) { | ||
| return Qnil; | ||
| } |
|
CI Results for f1e0dec:
|
|
Just curios, why did we remove it? |
|
whats the new equivalent of --verbose using the --loglevel stuff? |
|
We put it back. But |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.