Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed data documentation #4953

Merged
merged 2 commits into from Aug 30, 2023
Merged

Conversation

mdahlhausen
Copy link
Collaborator

Fixes #4947

This is a minor change to the data paragraph in the mainpage documentation. It makes loose reference to the DataEnums.hpp, but doesn't link to some important data enumerations,

The links to Vector.hpp, Matrix.hpp, and DataEnums.hpp appear broken, and this PR does not fix those.

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Aug 30, 2023
Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the vector matrix links

src/utilities/mainpage.hpp Outdated Show resolved Hide resolved
@jmarrec
Copy link
Collaborator

jmarrec commented Aug 30, 2023

Thanks @mdahlhausen !

@jmarrec jmarrec merged commit 0ab0280 into develop Aug 30, 2023
2 of 4 checks passed
@jmarrec jmarrec deleted the mainpage_data_documentation_edits branch August 30, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FuelType to utilities SDK documentation
2 participants