Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4969 - add json_schemer to embedded ruby gems #4974

Merged
merged 3 commits into from Sep 20, 2023
Merged

Fix #4969 - add json_schemer to embedded ruby gems #4974

merged 3 commits into from Sep 20, 2023

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Sep 19, 2023

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Ruby bindings labels Sep 19, 2023
@jmarrec jmarrec self-assigned this Sep 19, 2023
@jmarrec jmarrec marked this pull request as ready for review September 19, 2023 22:02
jmarrec
jmarrec commented Sep 19, 2023
View reviewed changes
CMakeLists.txt Outdated
set(OPENSTUDIO_GEMS_ZIP_FILENAME "openstudio3-gems-20230427-linux_arm64.tar.gz")
set(OPENSTUDIO_GEMS_ZIP_EXPECTED_MD5 "979a8839facf2fa1c4096dcbae39ddc2")
set(OPENSTUDIO_GEMS_ZIP_FILENAME "openstudio3-gems-20230918-linux_arm64.tar.gz")
set(OPENSTUDIO_GEMS_ZIP_EXPECTED_MD5 "TODO____TDB")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot I also need to build the arm64 linux package

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok built, added to google drive, should be hosted soonish.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been uploaded to S3 bucket. should ready to be used.

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Sep 20, 2023 •
edited

CI Results for 2555565:

@jmarrec jmarrec mentioned this pull request Sep 20, 2023
Merged
@jmarrec jmarrec merged commit 255c623 into develop Sep 20, 2023
4 of 6 checks passed
@jmarrec jmarrec deleted the 4969_json_schemer branch September 20, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit Awaiting requested review from shorowit

@wenyikuang wenyikuang Awaiting requested review from wenyikuang

Assignees

@jmarrec jmarrec

Labels
component - Ruby bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add json_schemer gem
3 participants
@jmarrec @ci-commercialbuildings @wenyikuang