Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4979 - Add operator __bool__ for optional in python bindings #4987

Merged
merged 4 commits into from Oct 17, 2023
Merged

Fix #4979 - Add operator __bool__ for optional in python bindings #4987

merged 4 commits into from Oct 17, 2023

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Sep 28, 2023

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Sep 28, 2023
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Sep 28, 2023
@jmarrec
Don't hard throw on pytest_discover_tests, if you have pytest but the…
0ed96ad 
… python bindings haven't been built yet it'll fail.

Maybe a good ol' regex like we do on the RubyTest would be better actually.
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Sep 28, 2023 •
edited

CI Results for 0ed96ad:

@kbenne kbenne self-requested a review October 17, 2023 15:09
@kbenne kbenne merged commit 7a987d3 into develop Oct 17, 2023
5 of 6 checks passed
@kbenne kbenne deleted the 4979_python__bool__ branch October 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenne kbenne Awaiting requested review from kbenne

Assignees

@jmarrec jmarrec

Labels
Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python bindings: usability improvements
3 participants
@jmarrec @ci-commercialbuildings @kbenne