Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the "labs" cli implementation the default #5006

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Make the "labs" cli implementation the default #5006

merged 3 commits into from
Oct 31, 2023

Conversation

kbenne
Copy link
Contributor

@kbenne kbenne commented Oct 28, 2023

The old implementation will be under the "classic" sub command.

close #5005

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@kbenne
Make the "labs" cli implementation the default
c5cbbea 
The old implementation will be under the "classic" sub command.

close #5005
@kbenne kbenne requested a review from jmarrec October 28, 2023 15:14
@kbenne
Copy link
Contributor Author

kbenne commented Oct 28, 2023

@DavidGoldwasser

@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Oct 29, 2023
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 29, 2023

Triggering CI on it. Assuming this comes clean, this can merge.

jmarrec
jmarrec reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jmarrec jmarrec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbenne Fixed the tests for you. I think CI will be clean after that. I added a banner to the "classic" CLI, please review that

src/cli/main.cpp
Comment on lines +77 to +82
fmt::print(fmt::fg(fmt::color::orange),
"┌{0:─^{2}}┐\n"
"│{1: ^{2}}│\n"
"└{0:─^{2}}┘",
"", "The `classic` command is deprecated and will be removed in a future release", 80);
fmt::print("\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbenne I added a banner to the "classic" subcommand, maybe you disagree with that part though? This can be reverted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jmarrec
Add -v,--version to print the version.
52a8cf8 
Perf tests were failing due to this being omitted
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 30, 2023 •
edited
Loading

@wenyikuang Seems like both the artifactory and the jenkins ci.openstudio.net itself certificates have just expired:

ERROR: HTTPSConnectionPool(host='conan.openstudio.net', port=443): Max retries exceeded with url: /artifactory/api/conan/openstudio/v1/ping (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1108)')))

Certificate was set to expire today: Mon, 30 Oct 2023 14:32:40 GMT

@wenyikuang
Copy link
Collaborator

wenyikuang commented Oct 30, 2023 •
edited
Loading

@wenyikuang Seems like both the artifactory and the jenkins ci.openstudio.net itself certificates have just expired:

ERROR: HTTPSConnectionPool(host='conan.openstudio.net', port=443): Max retries exceeded with url: /artifactory/api/conan/openstudio/v1/ping (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1108)')))

Certificate was set to expire today: Mon, 30 Oct 2023 14:32:40 GMT

confirmed, I cannot login either. Fixing.

update: fixed.

@jmarrec
Copy link
Collaborator

jmarrec commented Oct 30, 2023

Respawing CI runs now that the certificate is properly updated on conan.openstudio.net

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 30, 2023 •
edited
Loading

CI Results for 52a8cf8:

@jmarrec jmarrec merged commit 4d820d0 into develop Oct 31, 2023
5 of 6 checks passed
@jmarrec jmarrec deleted the 5005-make-labs-default branch October 31, 2023 11:22
@jmarrec jmarrec mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrec jmarrec jmarrec approved these changes

Assignees
No one assigned
Labels
Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "labs" subcommand the default
4 participants
@kbenne @jmarrec @wenyikuang @ci-commercialbuildings