[internal] Schedule:File relative paths mod #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leFile::translatedFilePath() const`
jmarrec
force-pushed
the
schedule-file-rel-path-2
branch
from
7683af4
to
d64e7fb
Compare
joseph-robertson
approved these changes
Oct 31, 2023
Comment on lines
+405
to
+417
| openstudio::path ScheduleFile_Impl::translatedFilePath() const { | ||
| if (translateFileWithRelativePath()) { | ||
| return toPath(externalFile().fileName()); | ||
| } | ||
| openstudio::path filePath = externalFile().filePath(); | ||
| if (!exists(filePath)) { | ||
| LOG(Warn, "Cannot find file \"" << filePath << "\""); | ||
| } else { | ||
| // make the path correct for this system | ||
| filePath = system_complete(filePath); | ||
| } | ||
| return filePath; | ||
| } |
| @@ -5111,7 +5111,9 @@ OS:Schedule:File, | |||
| \key Yes | |||
| \key No | |||
| \default Yes | |||
| A8; \field Translate File Name | |||
| A8; \field Translate File With Relative Path | |||
There was a problem hiding this comment.
Yes, this name more clear.
Comment on lines
+5115
to
+5116
| \note "No" means the absolute path of the ExternalFile is resolved and translated to IDF. | ||
| \note "Yes" means only the filename (relative) is translated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
openstudio::path ScheduleFile::translatedFilePath() constI'm building these changes, will hopefully report back soonish