Fix #5101 - Update monthly reports for DistrictHeatingWater

[jmarrec]

Pull request overview

• Companion PR: Fix #5101 - Update monthly reports for DistrictHeatingWater OpenStudio-workflow-gem#149

• Fix DistrictHeating meter is renamed to DistrictHeatingWater #5101
• Update monthly reports for DistrictHeatingWater

• Note for the name of the Output:Table:Monthly: AFAIK, this is OpenStudio::EndUseFuelType::valueDescription that is used by reporting measures so I made the change as well, perhaps some of them harcoded it to "District Heating", I'm not sure
• Electricity Peak Demand was missing Refrigeration EUT

To see the actual changes to the Output:Table:Monthly, just look at 8d3ff63?file-filters%5B%5D=.hpp&show-viewed-files=true

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

This openstudio script will directly generate RunPreprocessMonthlyReports.hpp
and can also save the OpenStudio-workflow-gem/lib/openstudio/workflow/jobs/resources/monthly_report.idf directly (yes, we do have these in both the legacy ruby workflow and the C++ workflow.)

[jmarrec]

Annoying to write in C++, but this test will ensure that this doesn't happen again.

[jmarrec]

I renamed the table here. I think it's right, but would welcome comments from @DavidGoldwasser in particular

as indicated in the OP: AFAIK, this is OpenStudio::EndUseFuelType::valueDescription that is used by reporting measures so I made the change as well, perhaps some of them harcoded it to "District Heating", I'm not sure

[DavidGoldwasser]

Added @joseph-robertson on to review of this PR as well

[jmarrec]

Meter name is renamed to DistrictHeatingWater

[jmarrec]

Refrigeration Was missing from Electricity Peak, I think that was a mistake, and it IS present in the Electricity report (energy)

[jmarrec]

Same meter rename for the peak one

[jmarrec]

And it's needed in meters forced too.

[joseph-robertson]

New script for generating RunPreprocessMonthlyReports.hpp 👍
New workflow tests for preventing future breaks 👍
Add missing Refrigeration:Electricity to Electricity Peak Demand 👍
Leaving it up to @DavidGoldwasser to comment on use of OpenStudio::EndUseFuelType::valueDescription in reporting measures.

[DavidGoldwasser]

I think reporting measure will be fine, but if a it breaks there I can make update before we release update to measures.