Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4847 logger singleton 3.1 #5119

Merged
merged 12 commits into from
Mar 27, 2024
Merged

4847 logger singleton 3.1 #5119

merged 12 commits into from
Mar 27, 2024

Commits on Mar 22, 2024

  1. Create a new Logger singleton type 

    Previously, we used the openstudio::Singleton template to create the
singleton named Logger. This implementation suffered a bug described
in #4847, where the singleton was not global across the ScriptEngine DLL
boundary.

This change is a non templated implementation of Logger. The design is
identical to openstudio::Singleton<LoggerSingleton>, but does not suffer
the non-global issue.

ref #4847
    @kbenne @jmarrec
    kbenne authored and jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2d0a76c View commit details
    Browse the repository at this point in the history

  2. Remove now duplicate and conflicting Logger template definition

    @kbenne @jmarrec
    kbenne authored and jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    659d01c View commit details
    Browse the repository at this point in the history

  3. Add test for Logger global instance

    @kbenne @jmarrec
    kbenne authored and jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3984b2b View commit details
    Browse the repository at this point in the history

  4. Make Logger::instance more global 

    UtilitiesAPI.hpp needs to be included by SWIG so that the correct
declspecs are used for the global logger. Previously, UTILITIES_API was
just #define OPENSTUDIO_API, therefore the dll export decorator was not
used.
    @kbenne @jmarrec
    kbenne authored and jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    aad08ee View commit details
    Browse the repository at this point in the history

  5. Rename LoggerSingleton to LoggerImpl 

    ref #4847
    @kbenne @jmarrec
    kbenne authored and jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    69c474b View commit details
    Browse the repository at this point in the history

  6. Remove poor man's hack for #4847

    @jmarrec
    jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c162c04 View commit details
    Browse the repository at this point in the history

  7. Break it up into Impl and hpp, use a Meyers singleton

    @jmarrec
    jmarrec committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    442cd38 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. clang-format

    @jmarrec
    jmarrec committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    96d111a View commit details
    Browse the repository at this point in the history

  2. Eliminate Logger_Impl

    @jmarrec
    jmarrec committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bca7f1b View commit details
    Browse the repository at this point in the history

  3. use map try_emplace to avoid copies

    @jmarrec
    jmarrec committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bf372b5 View commit details
    Browse the repository at this point in the history

  4. No need for try_emplace since we already check it's not in the map (c… 

    …ppcheck / clang format)
    @jmarrec
    jmarrec committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a13db45 View commit details
    Browse the repository at this point in the history

  5. Ignore loggerFromChannel properly for swig

    @jmarrec
    jmarrec committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    db83481 View commit details
    Browse the repository at this point in the history