Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ReportingMeasure template measure.py + use pathlib.Path in tests #5146

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix typo in ReportingMeasure template measure.py + use pathlib.Path in tests #5146

merged 1 commit into from
Apr 15, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Apr 15, 2024

Pull request overview

  • Fix typo in ReportingMeasure template measure.py + use pathlib.Path in tests>

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added the python Pull requests that update Python code label Apr 15, 2024
@jmarrec jmarrec self-assigned this Apr 15, 2024
jmarrec
jmarrec commented Apr 15, 2024
View reviewed changes
src/utilities/bcl/templates/ReportingMeasure/measure.py
@@ -269,7 +269,7 @@ def format_dt(dt):
</tr>
<tr>
<th scope="row">Maximum Site Outdoor Air Drybulb Temperature</th>
<td>{min(vals):.1f}</td>
<td>{max(vals):.1f}</td>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

src/utilities/bcl/templates/ReportingMeasure/measure.py
@@ -51,7 +51,7 @@ def arguments(self, model: openstudio.model.Model):

report_drybulb_temp = openstudio.measure.OSArgument.makeBoolArgument("report_drybulb_temp", True)
report_drybulb_temp.setDisplayName("Add output variables for Drybulb Temperature")
report_drybulb_temp.setDescription("Will add drybulb temp and report min/mix value in html.")
report_drybulb_temp.setDescription("Will add drybulb temp and report min/max values in html.")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

src/utilities/bcl/templates/ReportingMeasure/tests/test_reporting_measure.py
runner.setLastEnergyPlusSqlFilePath(openstudio.toPath(str(TestReportingMeasureName.sql_path(test_name))))
runner.setLastOpenStudioModelPath(model_out_path)
runner.setLastEpwFilePath(epw_path)
runner.setLastEnergyPlusSqlFilePath(TestReportingMeasureName.sql_path(test_name))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use pathlib.Path all the time

@jmarrec jmarrec merged commit c6dd282 into develop Apr 15, 2024
1 of 2 checks passed
@jmarrec jmarrec deleted the adjust_python_measure_templates branch April 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmarrec jmarrec

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jmarrec