Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system paths from default gem path #5191

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

kbenne
Copy link
Contributor

@kbenne kbenne commented May 9, 2024

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@kbenne kbenne self-assigned this May 9, 2024
@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label May 9, 2024
@kbenne
Copy link
Contributor Author

kbenne commented May 9, 2024

@joseph-robertson apparently I need to look at some test failures. 😞

Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this. Seems to resolve my issue.

@kbenne
Copy link
Contributor Author

kbenne commented May 9, 2024

I might not have caused these test failures (at least not with this PR) as there are failures on develop right now too. But in any case before we merge this, I'm going to use this branch to see about resolving the failures.

@DavidGoldwasser DavidGoldwasser mentioned this pull request May 14, 2024
60 tasks
@kbenne kbenne merged commit 3642275 into develop May 15, 2024
4 of 6 checks passed
@kbenne kbenne deleted the 5190-gem-search-path branch May 15, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.8.0 rc2 includes system paths in the gem search path
3 participants