Fix #5196 - valueAsJSON does not respect type

[jmarrec]

Pull request overview

• Fixes runner.getArgumentValues does not honor argument data type #5196

• Needs unit testing, but will write tomorrow. I just quick fixed it so @shorowit / @DavidGoldwasser have a chance to test it out before I wake up

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[shorowit]

Did a quick test with ruby and it works correctly. Thanks, @jmarrec!

[shorowit]

Can we remove this too? https://github.com/NREL/OpenStudio/blob/develop/src/cli/RunCommand.cpp#L37

[jmarrec]

Integer was broken after that quick fix.

Ok I see I got tripped up by reading a probably EXTREMELY outdated documentation for Json::Value (yeah, it's from 0.5.0...)

https://jsoncpp.sourceforge.net/class_json_1_1_value.html#ec4f74ef7b776b1d9c8a10fc3bb4add5

This commit from cough 13 years ago (json 0.7.0) changed the behavior

open-source-parsers/jsoncpp@1b138e8

[ci-commercialbuildings]

CI Results for c05003a:

• Ubuntu 20.04:

  • OpenStudio-3.8.0-rc2+c05003a002-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.8.0-rc2+c05003a002-Ubuntu-20.04-x86_64.tar.gz
  • perf_test/results.html

• Ubuntu 22.04:

  • OpenStudio-3.8.0-rc2+c05003a002-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.8.0-rc2+c05003a002-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.8.0-rc2+c05003a002-Darwin-x86_64.dmg
  • OpenStudio-3.8.0-rc2+c05003a002-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0-rc2+c05003a002-Windows.exe
  • OpenStudio-3.8.0-rc2+c05003a002-Windows.tar.gz

• Code Coverage: