Fix up uninitialized optional in getPastStepValuesForMeasure #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
the
Pull Request - Ready for CI
jmarrec
added a commit
to jmarrec/resstock
that referenced
this pull request
May 15, 2024
|
I created a new docker image from this run at https://registry.hub.docker.com/layers/nrel/openstudio/dev-pr-5199/images/sha256-3ac0f35ab7e11412fd38b7cf462fdb80ee612bd6c46a9370383e89676fbdfa17?context=explore And I'm testing the changes in NREL/resstock#1243 https://github.com/NREL/resstock/actions/runs/9100830729/job/25017139837?pr=1243#step:9:146 is all green! |
jmarrec
force-pushed
the
5192_getPastStepValuesForMeasure
branch
from
36de778
to
cff0d74
Compare
jmarrec
commented
May 15, 2024
Comment on lines
+431
to
+435
| { | ||
| const Json::Value stepValues = runner.getPastStepValuesForMeasure("non_existing"); | ||
| EXPECT_EQ(0, stepValues.size()); // did not set step result as Success | ||
| } | ||
| } |
There was a problem hiding this comment.
Crashing in debug mode before fix, works after
$ Products/openstudio_measure_tests --gtest_filter=*OSRunner_getPastStepValues_step_name_not_initialized*
Running main() from gmock_main.cc
Note: Google Test filter = *OSRunner_getPastStepValues_step_name_not_initialized*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from MeasureFixture
[ RUN ] MeasureFixture.OSRunner_getPastStepValues_step_name_not_initialized
openstudio_measure_tests: /home/julien/.conan2/p/b/boostfdc6e57e26853/p/include/boost/optional/optional.hpp:1270: boost::optional<T>::reference_type boost::optional<T>::get() [with T = std::__cxx11::basic_string<char>; boost::optional<T>::reference_type = std::__cxx11::basic_string<char>&]: Assertion `this->is_initialized()' failed.
Aborted (core dumped)
a65363a
to
879a7b6
Compare
…o optional not initialized ``` $ Products/openstudio_measure_tests --gtest_filter=*OSRunner_getPastStepValues_step_name_not_initialized* Running main() from gmock_main.cc Note: Google Test filter = *OSRunner_getPastStepValues_step_name_not_initialized* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from MeasureFixture [ RUN ] MeasureFixture.OSRunner_getPastStepValues_step_name_not_initialized openstudio_measure_tests: /home/julien/.conan2/p/b/boostfdc6e57e26853/p/include/boost/optional/optional.hpp:1270: boost::optional<T>::reference_type boost::optional<T>::get() [with T = std::__cxx11::basic_string<char>; boost::optional<T>::reference_type = std::__cxx11::basic_string<char>&]: Assertion `this->is_initialized()' failed. Aborted (core dumped) ```
old code works with std::optional, but not boost::optional 1.79.0 cf https://gcc.godbolt.org/z/7Khs774rd
jmarrec
force-pushed
the
5192_getPastStepValuesForMeasure
branch
from
879a7b6
to
3c4c28d
Compare
|
CI Results for 3c4c28d:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
old code works with std::optional, but not boost::optional 1.79.0
cf https://gcc.godbolt.org/z/7Khs774rd
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.