Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed PV daily lifetime loss arrays not being assigned correctly #288

Closed
cpaulgilman opened this issue Apr 24, 2020 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@cpaulgilman
Copy link
Collaborator

cpaulgilman commented Apr 24, 2020

Enabling AC or DC lifetime simulations from a default case without changing the array values results in a simulation error about the length of the array: exec fail(pvsamv1): Length of the lifetime daily DC losses array must be equal to the analysis period * 365 days/year

Applies to Detailed PV and PV Battery configurations.

Several potential issues here to investigate:

  • Default arrays for dc_lifetime_losses and ac_lifetime_losses are not correct length

  • UIObject property on Degradation AC DC Lifetime Daily UI form need to be updated to match widgets for inputs browser.

  • on_change() function called twice for en_dc_lifetime_losses

@cpaulgilman cpaulgilman added this to the 2020 Patch 2 milestone Apr 24, 2020
@cpaulgilman cpaulgilman self-assigned this Apr 24, 2020
@cpaulgilman
Copy link
Collaborator Author

cpaulgilman commented May 6, 2020

Also need to check default values of degradation variables for all configurations:

degradation

No default degradation for all LCOE Calculator and None

degradation = [0.5] for:

  • PVWatts

  • High-X Concentrating PV

degradation = [0] for all remaining configs

dc_degradation

dc_degradation = [0.5] for:

  • Flat Plate PV all except LCOE Calculator and None

  • Fuel Cell all

  • PV Battery all

No default dc_degradation for all other configs

generic_degradation

generic_degradation = [0] for all Generic Battery

No default generic_degradation for all other configurations.

dc_lifetime_losses, ac_lifetime_losses

ac_lifetime_losses = [0], dc_lifetime_losses = [0] for:

  • Flat Plate PV, except LCOE Calculator and None

  • PV Battery

No default ac_lifetime_losses or dc_lifetime_losses for all others

Default should be array of 365 * analysis_period.

Note that lifetime daily losses are not enabled for Fuel Cell configurations.

cpaulgilman added a commit that referenced this issue May 8, 2020
cpaulgilman added a commit that referenced this issue May 8, 2020
Manual merge of https://github.com/NREL/SAM/tree/fix_defaults_SAM296 because can't use GitHub to resolve conflicts for default txt files

Fix #296

Fix #288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant