Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar Resource multiple year download pagenote for PV uncertainty #1377

Merged
merged 3 commits into from Mar 23, 2023

Conversation

cpaulgilman
Copy link
Collaborator

Description

Fix pagenote text that appears after downloading multiple weather files and clean up inputs on Solar Resource and PV Albedo UI forms.

Fixes #1364

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 2 milestone Mar 17, 2023
@cpaulgilman cpaulgilman changed the title Pv uncertainty pagenote Solar Resource multiple year download pagenote for PV uncertainty Mar 17, 2023
@cpaulgilman cpaulgilman merged commit fcee45e into patch Mar 23, 2023
4 checks passed
@cpaulgilman cpaulgilman deleted the pv-uncertainty-pagenote branch March 23, 2023 21:25
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solar "Download files for all years" option displays old P50/P90 instructions
2 participants