Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update capex table installed cost calculations #1386

Merged
merged 3 commits into from May 4, 2023

Conversation

mjprilliman
Copy link
Collaborator

Description

-Move capex table calculations to equations to automatically update total installed cost for change in system capacity, battery capacity, land usage, or fuel cell capacity without re-loading the Installation Costs pages
-Needs code clean up

Fixes #1383

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the bug label Apr 4, 2023
@mjprilliman mjprilliman added this to the 2022.11.21 Patch 2 milestone Apr 4, 2023
@mjprilliman mjprilliman requested a review from brtietz April 4, 2023 19:30
@mjprilliman mjprilliman self-assigned this Apr 4, 2023
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, thanks for fixing!

@brtietz brtietz merged commit 8a04b32 into patch May 4, 2023
4 checks passed
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
@brtietz brtietz deleted the sam-1383-fix branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PV capital cost curves only update on load
3 participants