Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new BTM battery dispatch method for self-consumption #1446

Merged
merged 7 commits into from Sep 18, 2023

Conversation

janinefreeman
Copy link
Collaborator

This pull request and the complementary one in SAM add a new battery dispatch methodology for behind-the-meter PV+Battery and BTM battery hybrid systems that allow the battery to be dispatched to maximize self-consumption, which can also be termed "24/7 carbon-free energy" for larger industrial loads. Behind the scenes, this new dispatch option uses the grid power target option with the entire timeseries set to 0, but it is a new dispatch option to enable this functionality for PySAM users as well. Added a few new tests to go along with the new dispatch method.

  • [ x] New feature (non-breaking change which adds functionality)

  • [x ] This change requires a documentation update

  • [x ] My code follows the style guidelines of this project

  • [ x] I have performed a self-review of my own code

  • [x ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • [x ] My changes generate no new warnings

  • [ x] I have added tests that prove my fix is effective or that my feature works

  • [x ] New and existing unit tests pass locally with my changes

  • [x ] Any dependent changes have been merged and published in downstream modules

  • [x ] I have checked my code and corrected any misspellings

@janinefreeman janinefreeman added new feature battery requires help revision Requires a Help revision before releasing public version labels Sep 13, 2023
@janinefreeman janinefreeman added this to the SAM Fall 2023 Release milestone Sep 13, 2023
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, two nitpicks:

(1) IndexLabels appears to be missing self consumption

(2) How should the charge from grid checkbox be handled? My impression is it does nothing (which makes sense for the algorithm) but in that case should it be disabled?

@@ -267,7 +267,7 @@
"Label": "Battery dispatch choice",
"Units": " ",
"Group": "Battery Dispatch",
"IndexLabels": "",
"IndexLabels": "Peak shaving| Input grid power targets| Input battery power targets| Manual dispatch| Price signal forecast",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self consumption appears to be missing in the index labels.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dispatch algorithm doesn't make sense for a standalone system, so I didn't add it to this page. Is there a good place for me to add a comment as to why it's missing here? I'm sure others will have this same confusion...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right! The help documentation is likely the right spot for users. For us coders - does near the list of configurations in ssc make sense https://github.com/NREL/ssc/pull/1049/files#diff-ad752cc0b0fdf4cc68f248c6994ea37977572012346c2829d3efb51d61f0f90bR185 ?

@brtietz brtietz self-requested a review September 15, 2023 22:43
@brtietz brtietz changed the base branch from hybrids to develop September 18, 2023 15:47
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@brtietz brtietz merged commit c8e7e69 into develop Sep 18, 2023
4 checks passed
@janinefreeman janinefreeman deleted the carbonFreeDispatch branch September 18, 2023 19:32
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 10, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release battery new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants