New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set adj losses to zero for pv+battery cases #1463
Conversation
Changed to draft because I remembered that I need to re-run the test results for this type of change. Going to let #1462 go first, then I'll re-run the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for PV-battery configs.
All CSP and IPH configs have a adjust_constant = 4 by default except for:
MSPT, None
MSPT IPH, None
MSPT IPH, LCOH
Maybe set those to 4 to be consistent and then confirm with @tyneises and @taylorbrown75?
We ought to consider whether all IPH models should be something other than 4 considering they don't have a power block, but for now I think making everything 4 is a good plan |
…vailability_losses
…L/SAM into zero_out_availability_losses
Merge into develop losses fix I used during the battery webinar. Emails/SAM meeting feedback confirmed these weren't intentional.