Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set adj losses to zero for pv+battery cases #1463

Merged
merged 9 commits into from Oct 11, 2023

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Sep 25, 2023

Merge into develop losses fix I used during the battery webinar. Emails/SAM meeting feedback confirmed these weren't intentional.

@brtietz brtietz added this to the SAM Fall 2023 Release milestone Sep 25, 2023
@brtietz brtietz marked this pull request as draft September 25, 2023 22:05
@brtietz
Copy link
Collaborator Author

brtietz commented Sep 25, 2023

Changed to draft because I remembered that I need to re-run the test results for this type of change. Going to let #1462 go first, then I'll re-run the tests.

@brtietz brtietz marked this pull request as ready for review September 27, 2023 16:01
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for PV-battery configs.

All CSP and IPH configs have a adjust_constant = 4 by default except for:

MSPT, None
MSPT IPH, None
MSPT IPH, LCOH

Maybe set those to 4 to be consistent and then confirm with @tyneises and @taylorbrown75?

@tyneises
Copy link
Collaborator

Looks good for PV-battery configs.

All CSP and IPH configs have a adjust_constant = 4 by default except for:

MSPT, None MSPT IPH, None MSPT IPH, LCOH

Maybe set those to 4 to be consistent and then confirm with @tyneises and @taylorbrown75?

We ought to consider whether all IPH models should be something other than 4 considering they don't have a power block, but for now I think making everything 4 is a good plan

@brtietz brtietz merged commit a94a95a into develop Oct 11, 2023
2 of 4 checks passed
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
@brtietz brtietz deleted the zero_out_availability_losses branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants