Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrade to convert adjust table format to separate variables #1468

Merged
merged 2 commits into from Oct 4, 2023

Conversation

cpaulgilman
Copy link
Collaborator

Fixes #1392

File from 2022.11.21 r3 for testing: version-upgrade-adjust-test.zip

Note that because adjust variables do not have UI labels, the message in the Version Upgrade Report window shows "Changed to" with empty label:

version-upgrade

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Sep 27, 2023
@cpaulgilman cpaulgilman self-assigned this Sep 27, 2023
Add generic system
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cpaulgilman cpaulgilman merged commit b1aae77 into develop Oct 4, 2023
3 of 4 checks passed
@cpaulgilman cpaulgilman deleted the adjust-version-upgrade branch October 4, 2023 15:10
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update versions.lk for flattened SSC_TABLE variables
2 participants