Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1594 for hybrids and non-hybrids #1605

Merged
merged 4 commits into from Nov 29, 2023
Merged

Fixes #1594 for hybrids and non-hybrids #1605

merged 4 commits into from Nov 29, 2023

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Nov 28, 2023

No description provided.

@sjanzou sjanzou self-assigned this Nov 28, 2023
@sjanzou sjanzou linked an issue Nov 28, 2023 that may be closed by this pull request
Parametrics import function doesn't work #1594
Closed
@sjanzou
Copy link
Collaborator Author

sjanzou commented Nov 28, 2023

Note that test script will fail until #1581 is merged into develop and develop merged into SAM_1594 branch of SAM

cpaulgilman
cpaulgilman approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: Tested import/export parametrics with hybrid and non-hybrid configs, and opening SAM 2022.11.21 file with parametrics.

@sjanzou sjanzou merged commit 863a0dd into develop Nov 29, 2023
2 checks passed
@sjanzou sjanzou deleted the SAM_1594 branch November 29, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@janinefreeman janinefreeman Awaiting requested review from janinefreeman

Assignees

@sjanzou sjanzou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parametrics import function doesn't work
2 participants
@sjanzou @cpaulgilman