Fix solar resource download geocoding issues

[cpaulgilman]

Pull Request Template

Description

NSRDB downloads from Solar Resource input page was submitting user input string to geocode() function, assuming that the geocoding API parses the string to determine if it is a street address, location, name, or lat/lon pair. However, geocode() function sends input string to the MapQuest Geocode Address API, which requires a street address or location name as input: https://developer.mapquest.com/documentation/geocoding-api/address/get/. The private NREL developer geocoding API is a wrapper for the MapQuest API, and is not designed to take lat/lon as input.

Items fixed:

• Update Solar Resource UI callback to not use lat/lon as input geocode function. If user input string appears to be lat/lon, submit that directly to NSRDB instead of geocoding it.
• Update Advanced Download to show lat/lon returned by geocoding function to help with troubleshooting
• Revise LK geocode() function documentation to remove lat/lon as input option.
• Change geocode function to return latLon instead of displayLatLon to latLon. See MapQuest documentation for justification.

Note related issues that will be fixed in separate pull requests:

• Advanced NSRDB download updates #1534
• Create an error if someone enters Lat/Long pairs with N,s,e,w and show them the proper format. #1426

Fixes #1526

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[cpaulgilman]

Testing this requires building SAM-private. to get that to work, I had to modify the SAM-private CMakeLists.txt to comment out the SDK tool settings:

To run the private version from Visual Studio 2022:

1. Build SAMOS. (open source)
2. Clean SAM solution and rebuild. (SAM private)
3. Run SAM.

[sjanzou]

For me, SAM-private built without issue using the unmodified CMakeLists.txt in the patch branch.

The more detailed feedback is great:

However, -39,105 creates a callback error:

[cpaulgilman]

@sjanzou ea6c555 should resolve the callback issue and also adds support for downloading international data.

Here's a CSV file with a list of location names and lat/lon pairs for places around the world and available NSRDB datasets and and LK script that creates it that might be helpful for testing: nsrdb-endpoints.zip

[sjanzou]

Working for all valid lat/lon tested and for values for which there is no NSRDB data, returns all information we have; e.g.