Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset adjust periods to three zero columns when no custom period is set #1698

Merged
merged 1 commit into from Feb 19, 2024

Conversation

mjprilliman
Copy link
Collaborator

Pull Request Template

Description

-Make adjust_periods= [0;0;0] when no custom period is set, avoid 3 column var table error when periods are not required.

Fixes #1668

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added bug UI User interface issue that applies across performance and financial models labels Feb 13, 2024
@mjprilliman mjprilliman added this to the 2023 Release Patch 1 milestone Feb 13, 2024
@mjprilliman mjprilliman self-assigned this Feb 13, 2024
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@mjprilliman mjprilliman merged commit 29c97b9 into patch Feb 19, 2024
4 checks passed
@mjprilliman mjprilliman deleted the adjust-periods-reset branch February 19, 2024 17:04
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release bug UI User interface issue that applies across performance and financial models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PV losses requires time series losses with custom periods even when disabled
3 participants