Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix battery life defaults #1715

Merged
merged 3 commits into from Feb 29, 2024
Merged

Fix battery life defaults #1715

merged 3 commits into from Feb 29, 2024

Conversation

cpaulgilman
Copy link
Collaborator

  • Use correct battery life table for default battery type
  • Set exclusive var so UI is in correct state

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1680

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

* Use correct battery life table for default battery type
* Set exclusive var so UI is in correct state
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Feb 27, 2024
@cpaulgilman cpaulgilman self-assigned this Feb 27, 2024
cpaulgilman and others added 2 commits February 27, 2024 16:23
Expect small changes for configurations with batteries that used wrong battery life table.
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@cpaulgilman cpaulgilman merged commit e83363d into patch Feb 29, 2024
4 checks passed
@cpaulgilman cpaulgilman deleted the batt-life-defaults branch February 29, 2024 16:19
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery Life default state of UI incorrect
3 participants