Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed self-consumption from PPA revenue section of Cashflow, moved to Electricity purchase #785

Merged
merged 2 commits into from Nov 19, 2021

Conversation

mjprilliman
Copy link
Collaborator

@mjprilliman mjprilliman commented Nov 19, 2021

Parasitics in Cashflow

Description

The Cashflow tab previously had rows for PPA self-consumption and electricity purchases in separate sections. As the parasitic load costs are now always treated as an operating cost, the cashflows.lk script was reorganized to always have the parastic load cost appear under Electricity purchase.

Probably still requires changes for Send to Excel with Equations

*ssc changes already in develop

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2021 Release milestone Nov 19, 2021
@mjprilliman mjprilliman self-assigned this Nov 19, 2021
@mjprilliman mjprilliman changed the title Removed self-consumption from PPA revenue, parasitics always stored in Removed self-consumption from PPA revenue section of Cashflow, moved to Electricity purchase Nov 19, 2021
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I will update send-to-Excel with equations with #694.

Default retail rates need to be updated for all technologies to a flat energy rate with no fixed or demand charges. For example, Empirical Trough / Single Owner has a default fixed monthly charge of $39.72 and tiered demand charges.

@mjprilliman mjprilliman merged commit 35ad4d6 into develop Nov 19, 2021
@mjprilliman mjprilliman deleted the parasitic_cashflow_fixes branch November 19, 2021 18:06
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants