Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Actions #24

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Added GitHub Actions #24

merged 5 commits into from
Mar 3, 2021

Conversation

johnjasa
Copy link
Collaborator

Added two GH Actions scripts.
CI_every_commit runs on every push to WindSE and is where the Coveralls data is obtained.
CI_every_PR runs only on PR commits and contains longer tests, including the demos.

I've also added some PR and issue templates for GitHub

@jefalon
Copy link
Collaborator

jefalon commented Feb 25, 2021

Woah that was quick, Well done! What's the difference between these tests:

 CI_every_commit / Build (ubuntu-latest) (pull_request)
 CI_every_commit / Build (ubuntu-latest) (push)

@johnjasa
Copy link
Collaborator Author

Thanks! And great question. It's the same test so there's a bit of redundancy in this case. Why it's needed is that we want CI_every_commit to run for each push, but also for PRs. But if you have it set to only be run on pushes and not PRs, then I think there are situations where you can open a PR without triggering a push event. This introduces a double test that we can ignore, but is necessary for some edge case PRs.

@jefalon jefalon merged commit 418a1eb into dev Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants