Pseudo-Steady Solver Logic #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyoung55
commented
Jul 9, 2021
Comment on lines
+1000
to
+1003
| # FIXME: We should be consistent about which way the turbine | ||
| # forces are oriented. | ||
| if self.farm.turbine_method != "alm": | ||
| self.tf *= -1.0 |
There was a problem hiding this comment.
@jefalon what do you think about standardizing the direction the turbine force points? I'd like to swap everything so that turbine forces point opposite the incoming flow, but recognize that ALM is the odd one out and it would be easier to bring it into line with the others.
There was a problem hiding this comment.
I think that's a good idea and having it opposite to flow is logical since it's suppose to be forcing it to slow down. Thinks to check to make sure this sign flip doesn't break anything is:
- the sign of the tf term in the system functional for both the stabilized and Taylor hood steady solver
- the sign on the power and 2d_power objective functions
- probably some other place I can't think of
There was a problem hiding this comment.
We need to fix the opt output for plotting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to specify
final_time = nonein the yaml to trigger a pseudo-steady run of the unsteady solver, where the solver will continue iterating until the average velocity field converges.stability_eps: 0)It most likely won't pass GHA because it also uses the fast/optimized solver+preconditioner pairs which leads to slightly different results.