Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed inflow_angle bug and power sum bug #81

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

jefalon
Copy link
Collaborator

@jefalon jefalon commented Nov 29, 2021

Delete the text explanations below these headers and replace them with information about your PR.

Purpose

This PR fixes a bug with the inflow angle. Additionally, this should fix #78.

Type of change

Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

No new testing is needed, though we might want to add a multiangle regression test in the future rather than it just being a demo

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@jefalon jefalon merged commit 634c6ab into NREL:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power output summation bug
1 participant