This repository has been archived by the owner on Jan 7, 2018. It is now read-only.
Better error handling for if error data is unexpectedly not an object. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to it being possible to enter invalid error data (but valid YAML) via the web UI: NREL/api-umbrella#153 In these cases, we will now return the default internal server error, which at least prevents bad error responses without an HTTP status code at all, which could really throw some clients for a tizzy.
GUI
added a commit
that referenced
this pull request
Jun 15, 2015
Better error handling for if error data is unexpectedly not an object.
GUI
added a commit
that referenced
this pull request
Jul 27, 2015
Ensure that the error data yaml entered is the expected type (hash)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to it being possible to enter invalid error data (but valid YAML) via the web UI: NREL/api-umbrella#153
In these cases, we will now return the default internal server error, which at least prevents bad error responses without an HTTP status code at all, which could really throw some clients for a tizzy.