Skip to content

Commit

Permalink
Hook up nginx settings for defining error log level. Default to warn.
Browse files Browse the repository at this point in the history
We previously had this configuration item defined, but it wasn't
actually being used in the nginx config.
  • Loading branch information
GUI committed Jun 30, 2018
1 parent d901910 commit 2b0c8ac
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ listen:
nginx:
workers: auto
worker_connections: 8192
error_log_level: notice
error_log_level: warn
access_log_filename: access.log
access_log_options: buffer=256k flush=10s
proxy_connect_timeout: 60
Expand Down
3 changes: 3 additions & 0 deletions config/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ nginx:
# hard-coded for test purposes so we have a more stable baseline and ensure
# our tests always run with multiple workers.
workers: 2
# Disable log output buffering for immediate output in tests.
access_log_options:
# Increase error log verbosity in tests.
error_log_level: notice
proxy_connect_timeout: 10
proxy_read_timeout: 10
proxy_send_timeout: 10
Expand Down
2 changes: 1 addition & 1 deletion templates/etc/nginx/auto-ssl.conf.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ events {
worker_connections {{auto_ssl.worker_connections}};
}

error_log stderr;
error_log stderr {{nginx.error_log_level}};

pcre_jit on;

Expand Down
2 changes: 1 addition & 1 deletion templates/etc/nginx/router.conf.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ events {
worker_connections {{nginx.worker_connections}};
}

error_log stderr;
error_log stderr {{nginx.error_log_level}};

env API_UMBRELLA_SRC_ROOT;
env API_UMBRELLA_RUNTIME_CONFIG;
Expand Down

0 comments on commit 2b0c8ac

Please sign in to comment.