Skip to content

Commit

Permalink
Removed deprecated nMods and nRows inputs and warning to makeScene1axis
Browse files Browse the repository at this point in the history
Deprecation warning on makeScene1axis has been there for a long time. Time to remove it. Addresses #208 for next release.
  • Loading branch information
shirubana committed Nov 27, 2019
1 parent c5cafa0 commit c2386c8
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions bifacial_radiance/main.py
Expand Up @@ -1843,7 +1843,7 @@ def appendtoScene(self, radfile=None, customObject=None, text=''):


def makeScene1axis(self, trackerdict=None, moduletype=None, sceneDict=None,
cumulativesky=None, nMods=None, nRows=None, hpc=False):
cumulativesky=None, hpc=False):
"""
Creates a SceneObj for each tracking angle which contains details of the PV
system configuration including row pitch, hub_height, nMods per row, nRows in the system...
Expand Down Expand Up @@ -1895,20 +1895,6 @@ def makeScene1axis(self, trackerdict=None, moduletype=None, sceneDict=None,
'and .pitch or .gcr')
return

# Check for deprecated variables and assign to dictionary.
if nMods is not None or nRows is not None:
print("nMods and nRows input is being deprecated. Please include"+
"nMods and nRows inside of your sceneDict definition")
print("Meanwhile, this funciton will check if SceneDict has nMods"+
" and nRows and will use that as values, and if not, "+
"it will assign nMods and nRows to it.")

if sceneDict['nMods'] is None:
sceneDict['nMods'] = nMods

if sceneDict['nRows'] is None:
sceneDict['nRows'] = nRows

# If no nRows or nMods assigned on deprecated variable or dictionary,
# assign default.
if 'nRows' not in sceneDict:
Expand Down

0 comments on commit c2386c8

Please sign in to comment.