Gencumsky fix #162
Merged
Gencumsky fix #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no longer moved to /EPWs/.
… - requires MS visual studio C++ or other compiler to work.
|
Still need to verify starttime and endtime functionality is working fully... |
|
OK, this pull request is ready to go. This adds gencumsky to the test suite, but in the process I realized that I need to have the test window ridiculously large, like 1000 Wm-2 +/- 60 as opposed to +/- 2 Wm-2 for gendaylit. I don't think that I'm doing anything wrong, but I don't remember it being this bad... |
|
I should probably check that this new functionality works with the gui... |
|
All of the notebooks in development work with this version. |
|
I found a different unrelated bug with the GUI where it's not taking input correctly into modelchains. It's fixed now. This pull request is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both TMY and EPW weather files now have a 'starttime' and 'endtime' string passed that allow you to specify 'MM_DD_HH' start and end times for the file. readEPW also retains the 'daydate' input option. Also, EPW files are now treated exactly like tmy files for the purpose of gencumsky - namely a temp_epw.csv file is created in \EPWs, and gencumsky.exe is called with the -G mode instead of -E mode.