New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0332 release #235
0332 release #235
Commits on Oct 15, 2019
-
Ayala committed
Oct 15, 2019 Configuration menu - View commit details
-
Copy full SHA for e6236b6 - Browse repository at this point
Copy the full SHA e6236b6View commit details -
Ayala committed
Oct 15, 2019 Configuration menu - View commit details
-
Copy full SHA for e3b34a0 - Browse repository at this point
Copy the full SHA e3b34a0View commit details
Commits on Oct 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 77ebd7e - Browse repository at this point
Copy the full SHA 77ebd7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d03538 - Browse repository at this point
Copy the full SHA 2d03538View commit details
Commits on Oct 21, 2019
-
Squashed commit of the following:
commit 679f9b5 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Sat Oct 19 10:55:20 2019 -0600 paper commit 9c134c3 Author: Ayala <sayala@nrel.gov> Date: Fri Oct 18 12:26:36 2019 -0600 last test paper commit fc551f4 Author: Ayala <sayala@nrel.gov> Date: Fri Oct 18 12:25:29 2019 -0600 paper commit 9740162 Author: Ayala <sayala@nrel.gov> Date: Fri Oct 18 12:24:06 2019 -0600 paper test 3 commit edd8ea4 Author: Ayala <sayala@nrel.gov> Date: Fri Oct 18 12:20:08 2019 -0600 image_paper test2 commit ce10fb5 Author: Ayala <sayala@nrel.gov> Date: Fri Oct 18 12:15:43 2019 -0600 paper commit 44950e6 Author: Ayala <sayala@nrel.gov> Date: Fri Oct 18 11:05:31 2019 -0600 paper commit 1d72247 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Thu Oct 17 10:28:44 2019 -0600 rename Webinar Slides commit 7940830 Merge: 6689d49 770ec16 Author: cdeline <chris.deline@nrel.gov> Date: Wed Oct 16 17:06:46 2019 -0600 Merge pull request NREL#180 from NREL/webinaR_FIXES Webinar fixes commit 770ec16 Merge: 95ccc96 54d08ba Author: cdeline <chris.deline@nrel.gov> Date: Wed Oct 16 16:57:36 2019 -0600 Merge branch 'webinaR_FIXES' of https://github.com/NREL/bifacial_radiance into webinaR_FIXES commit 95ccc96 Author: cdeline <chris.deline@nrel.gov> Date: Wed Oct 16 16:57:26 2019 -0600 allow null values for modWanted and rowWanted commit ed8be07 Author: cdeline <chris.deline@nrel.gov> Date: Wed Oct 16 16:47:22 2019 -0600 Fix GUI load issue when None values passed. set gui default modWanted and rowWanted = Null. commit 54d08ba Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Oct 16 16:07:03 2019 -0600 Equation_ShadingFactor.png commit 72fa374 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Oct 16 15:51:05 2019 -0600 Shading factor + TutorialSlides commit 6689d49 Author: Ayala <sayala@nrel.gov> Date: Tue Oct 15 17:00:05 2019 -0600 bib commit f95b743 Author: Ayala <sayala@nrel.gov> Date: Tue Oct 15 16:47:01 2019 -0600 bib commit 918cdf4 Author: Ayala <sayala@nrel.gov> Date: Tue Oct 15 16:41:42 2019 -0600 paper.bib commit 7d7bf11 Author: Ayala <sayala@nrel.gov> Date: Tue Oct 15 16:37:03 2019 -0600 bibtex update commit 9b158a2 Author: Ayala <sayala@nrel.gov> Date: Tue Oct 15 16:30:59 2019 -0600 paper draft1 need to upload to see if it compiles commit e50e5b8 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Mon Oct 14 15:13:28 2019 -0600 readme license update to mention Alliance commit b47a907 Author: cdeline <chris.deline@nrel.gov> Date: Mon Oct 14 12:56:51 2019 -0600 Update README.md commit 2296c2a Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Mon Oct 14 12:52:29 2019 -0600 sphinx doc. v0.3.3 commit 5016b6b Merge: fa8ea39 db45e6f Author: cdeline <chris.deline@nrel.gov> Date: Mon Oct 14 12:26:11 2019 -0600 Merge pull request NREL#145 from NREL/development Development merge for v0.3.3
Configuration menu - View commit details
-
Copy full SHA for df6070f - Browse repository at this point
Copy the full SHA df6070fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b8ea5 - Browse repository at this point
Copy the full SHA 13b8ea5View commit details -
Merge pull request NREL#182 from mikofski/add_gencumsky_src
Add gencumsky src
Configuration menu - View commit details
-
Copy full SHA for da2af16 - Browse repository at this point
Copy the full SHA da2af16View commit details -
Configuration menu - View commit details
-
Copy full SHA for d32d519 - Browse repository at this point
Copy the full SHA d32d519View commit details
Commits on Nov 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 503ee6e - Browse repository at this point
Copy the full SHA 503ee6eView commit details -
Merge branch 'master' of https://github.com/NREL/bifacial_radiance in…
…to development
Configuration menu - View commit details
-
Copy full SHA for f3bd03a - Browse repository at this point
Copy the full SHA f3bd03aView commit details
Commits on Dec 10, 2019
-
Squashed commit of the following:
commit f46571f Merge: 77f4d33 d847937 Author: cdeline <chris.deline@nrel.gov> Date: Tue Dec 10 14:25:27 2019 -0700 Merge pull request NREL#199 from NREL/master-JOSS Modifications to address documentation suggestions by JOSS reviewers commit d847937 Author: cdeline <chris.deline@nrel.gov> Date: Tue Dec 10 14:18:06 2019 -0700 Revert "Removed deprecated nMods and nRows inputs and warning to makeScene1axis" This reverts commit c2386c8. commit 1df9d2d Merge: 6338954 9047fdf Author: cdeline <chris.deline@nrel.gov> Date: Tue Dec 10 14:06:50 2019 -0700 Merge branch 'master-JOSS' of https://github.com/NREL/bifacial_radiance into master-JOSS commit 6338954 Author: cdeline <chris.deline@nrel.gov> Date: Tue Dec 10 14:06:41 2019 -0700 remove extraneous tutorial1 .py file commit 9047fdf Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Fri Dec 6 22:13:57 2019 -0700 update installation.rst commit 8c0f63e Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Fri Dec 6 21:56:35 2019 -0700 installation PR fix commit 7a9000a Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Fri Dec 6 08:23:13 2019 -0700 journal2 path fix NREL#217 commit b090a15 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Fri Dec 6 07:32:06 2019 -0700 small fix NREL#217 Just journal 1 atm, testing it. commit d360efa Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 13:35:36 2019 -0700 package overview NREL#191 Added text and images to package overview. Also added link to Webinar tutorial as the package is very well explained there with animations commit 3ee75cd Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 12:37:30 2019 -0700 Update installation.rst Addresses various comments on PR NREL#199 commit af43110 Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 12:08:56 2019 -0700 platform and python version updates NREL#198 updated paper, instead of adding the installer, for the moment. Created a issue-wishlist to add other platforms at a later time (NREL#214) commit 2cc760e Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 12:01:01 2019 -0700 improvements to contributing NREL#196 commit f5ebf9e Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 11:40:24 2019 -0700 added citations paper.md NREL#197 NREL#193 Added citations pvlib, pvfactors, pvsyst and sam citations commit 04db364 Merge: ea8e752 77f4d33 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Thu Dec 5 10:47:48 2019 -0700 Merge branch 'master' into master-JOSS commit ea8e752 Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 10:41:21 2019 -0700 pytest otherfix and notes commit 77f4d33 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Thu Dec 5 10:38:14 2019 -0700 citation on readme update NREL#213 commit 9818770 Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 10:36:57 2019 -0700 update main citation NREL#213 It's updated on JOSS but since not sure when we're merging, updating here. commit a452fd2 Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 10:33:25 2019 -0700 update to DOE citation NREL#213 update to main DOE citation -- modified 11/18. commit fe3923f Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 10:24:50 2019 -0700 dumb dumb fix commit 27f4ef8 Author: Ayala <sayala@nrel.gov> Date: Thu Dec 5 10:17:53 2019 -0700 pytest smallfix asserting file names varies between my computer and online due to skies/skyblablah or skies\\skyblablah so changed the assertion to just 'skies' commit c2386c8 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 16:31:10 2019 -0700 Removed deprecated nMods and nRows inputs and warning to makeScene1axis Deprecation warning on makeScene1axis has been there for a long time. Time to remove it. Addresses NREL#208 for next release. commit c5cafa0 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 16:28:20 2019 -0700 pytest getSingleTimestampTrackerAngle commit e0af625 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 16:01:47 2019 -0700 added small pytests added pytests for exportTrackerDict(), and makeModule() (empty input), and added hpc=True on makeOct and makeImage to go over those lines as well. commit 98932d3 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 15:35:16 2019 -0700 pytest sceneDict HEIGHT options on makeScene1axis added some validations for various height input options. it'd be awesome if we deprecated all of this options and just made it obligatory to use hub_height and clearance_height,... it would trim many dumb lines of code and warnings. commit 2f05732 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 15:27:01 2019 -0700 add test for makeImage and makeFalseColor, small fix gendaylit2manual test commit a039529 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 15:13:41 2019 -0700 pytest gendaylit2manual, small fix test_1axis_genCumSky() added gendaylit2manual test small fix test_1axis_genCumSky(): I removed the ygap of the makeModule so the assertion didn't work. Added it back commit 9d1c6fa Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 15:04:01 2019 -0700 pytest Torquetubes smallfix assertion was too long for Python 2.7, so reduced it :) commit 08a579e Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 14:59:32 2019 -0700 makeSCene1axis test for sceneDict with Pitch and with GCR (NREL#204 test) pytest improvement, doesn't solve but helps identify if NREL#204 is addressed. commit 1252917 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 14:45:42 2019 -0700 added test_1axis_gencumSky() Improves coverage by another 1% :D now at 68% commit f2297f2 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 14:19:41 2019 -0700 pytest TorqueTubes on Modules Improves coverage by 2%, by making different modules with torquetubes of diff. shapes. Ta-da :D commit 856049c Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 14:05:52 2019 -0700 quickExample fix NREL#201 and pytest adding testfolder optional input to quickExample() so it can be used in the pytest, and also returning analysis so it can be used in the pytest. Also calls now the interative directory from main.py instead of re-defining it inside. Solves NREL#201 Added pytest commit bedea2a Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 13:08:31 2019 -0700 remove HPCExample from main.py, add HPCExample Tutorial Notebook remove HPCExample from main.py, add HPCExample Tutorial Notebook. It was not working as an internal function nayways it was mostly for demonstration. Now as a journal it almost does stuff... still need to debug why it's not going into runJob(). Improves coverage by 2% (now at 64!) commit 76c2767 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Wed Nov 27 11:46:52 2019 -0700 pytest getEPW added test for lines 424-495 (71 continuous lines) for getEPW. 2% improvement in coverage of Main (at 62% now. commit cd709aa Author: cdeline <chris.deline@nrel.gov> Date: Tue Nov 19 09:53:28 2019 -0700 move make_gencumsky directions into optional note. commit f21b502 Author: cdeline <chris.deline@nrel.gov> Date: Tue Nov 19 09:43:07 2019 -0700 update Linux installation and make_gencumsky note. commit c0334b1 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Tue Nov 19 09:20:40 2019 -0700 Addressing NREL#194 Addresing NREL#194 Jupyter dependency: -Mentioned on installation, that it is suggested to install the latest Anaconda to also get Jupyter for use with the tutorials. -Added the code snippet to setup.py commit 8b7c683 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Tue Nov 19 09:00:12 2019 -0700 Addresses NREL#192, NREL#193 Addressing NREL#192 Intended Audience: -Modified index page of documentation to include intended audience -Modified paper.md to include intended audience. Addressing NREL#193 State of hte Field: -Added state of hte field description, with tools comparable to bifacial_radiance and agreement in paper.md -Still need to address pvfactors and pvlib mention and references. commit 3fe059c Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Tue Nov 19 08:55:25 2019 -0700 Addressing NREL#190 Improvement of installation instructions NREL#190: -Mention of pip install option -Added section dedicated to compatibility -- linux based systems OK -Step 2 on install mentiosn how to install for Linux/Mac OSX steps. -Step 3 phrasing on 'Scene' was modified/expanded for clarity. -Youtube's description now includes updates to mention how to pip install bifacial_radiance, pip install pvlib, and comments for Linux/Mac OSX users to read the install guide on readthedocs. commit e5aa985 Merge: 5274425 0865425 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Tue Nov 19 08:23:33 2019 -0700 Merge branch 'master' of https://github.com/NREL/bifacial_radiance commit 5274425 Author: Silvana Ayala <silvana.ayala@nrel.gov> Date: Tue Nov 19 08:23:26 2019 -0700 Journal 8 small date change ~ Modified end date of data query to one day after, otherwise it got an empty array. commit 0865425 Author: cdeline <chris.deline@nrel.gov> Date: Mon Nov 18 13:02:42 2019 -0700 Standard BSD-3, remove special notice.
Configuration menu - View commit details
-
Copy full SHA for 9a2907c - Browse repository at this point
Copy the full SHA 9a2907cView commit details -
Removed deprecated nMods and nRows inputs and warning to makeScene1axis
Deprecation warning on makeScene1axis has been there for a long time. Time to remove it. Addresses NREL#208 for next release.
Configuration menu - View commit details
-
Copy full SHA for 90e8a46 - Browse repository at this point
Copy the full SHA 90e8a46View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5fe76f - Browse repository at this point
Copy the full SHA a5fe76fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5750ec3 - Browse repository at this point
Copy the full SHA 5750ec3View commit details
Commits on Dec 17, 2019
-
modified sorting of tracker keys to demo.trackerdict since trackerdict is not being assigned on the first cell. Also, modified enddate to 11/07, otherwise empty array.
Configuration menu - View commit details
-
Copy full SHA for 65df881 - Browse repository at this point
Copy the full SHA 65df881View commit details
Commits on Dec 28, 2019
-
_tempTMY saves a file with the daydate now if available so it doesnt get overwritten/overreda. importnat fix to sky generation on gendaylit1axis, because the for loop was going to endindex+1 before. analysis1axis added input for daydate, so cumulative file adds for hte daydate. The other option is to turn off the cumulative file saving option for daydate? discuss Main has the script to run the runJOB on multiprocessing. It's not worknig super good though. Summary: 1) 8 cores on my computer: It uses all cores on the computer 2) HPC: seems to be using both Nodes (for a 60 day simulatoin), but only starts printing stuff for one of the cores... the other one appears some of the results but later, does that means it's being assigned afterwards to the same initial node?
Configuration menu - View commit details
-
Copy full SHA for 48ef35b - Browse repository at this point
Copy the full SHA 48ef35bView commit details
Commits on Jan 2, 2020
-
test2 ist he most updated. Delete this files when finishing with development....
Ayala committedJan 2, 2020 Configuration menu - View commit details
-
Copy full SHA for 7a17c1b - Browse repository at this point
Copy the full SHA 7a17c1bView commit details
Commits on Jan 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ff018fe - Browse repository at this point
Copy the full SHA ff018feView commit details -
implement of NREL#186 , fix NREL#226
This seems to solve issue NREL#226 for vertical modules. Uses the code suggested on NREL#185 and PR NREL#186 , except for the xinc/2 and zinc/2. Does not seem to be necessary? At least for 4 sensors, it places it correctly at tilt = 0. Look at x,y and z rears (the front is hte one that has the offset of the module thickness). Also this particular fix would only work for E/W facing modules.
Ayala committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 4e1df7b - Browse repository at this point
Copy the full SHA 4e1df7bView commit details -
pytest small fix for orientation and coord starts
since orientations x and y changed did the updates. also, xstart, ystart and zstart are slightly different now that they are closer to the module surface. pytest still not passing because of modelchain.py though ~~ check
Ayala committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 2a9d0ec - Browse repository at this point
Copy the full SHA 2a9d0ecView commit details
Commits on Jan 7, 2020
-
Added Mac OSX Instructions w Quartz from notes on MacBook pro usage from and Alternative Installation with Windows Subsystem for Linux. from @mikofski , and @CameronTStark github and email threads. This adds information of users who have bifacial_radiance on other platforms to address openjournals/joss-reviews#1865 Clarified that the gencumksy executable for linux is the one without the .exe that should be moved to the folder addressing issue on NREL#223 Fix contradiction on NREL#222.
Ayala committedJan 7, 2020 Configuration menu - View commit details
-
Copy full SHA for d455d8a - Browse repository at this point
Copy the full SHA d455d8aView commit details -
Ayala committed
Jan 7, 2020 Configuration menu - View commit details
-
Copy full SHA for 7b5b8b0 - Browse repository at this point
Copy the full SHA 7b5b8b0View commit details -
cumulative results save Try-except
I don't think this was the main issue with why the pytest was failing, but this helped in case the file can't be written for whatever reason (i.e. no trackerdict -- which was the issue.)
Ayala committedJan 7, 2020 Configuration menu - View commit details
-
Copy full SHA for 395c76c - Browse repository at this point
Copy the full SHA 395c76cView commit details
Commits on Jan 20, 2020
-
must assign z to be a smaller value otherwise it work weird. z= 0.0002 for example, for 200 nm
Configuration menu - View commit details
-
Copy full SHA for ba74fc0 - Browse repository at this point
Copy the full SHA ba74fc0View commit details
Commits on Feb 5, 2020
-
Added glass material description, stock_glass like in radiance guide example.
Ayala committedFeb 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 5ddba0a - Browse repository at this point
Copy the full SHA 5ddba0aView commit details
Commits on Feb 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9a55a25 - Browse repository at this point
Copy the full SHA 9a55a25View commit details
Commits on Apr 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for dd595a2 - Browse repository at this point
Copy the full SHA dd595a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e25b20 - Browse repository at this point
Copy the full SHA 3e25b20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af07f1 - Browse repository at this point
Copy the full SHA 0af07f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4d6c4f - Browse repository at this point
Copy the full SHA a4d6c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc2b91 - Browse repository at this point
Copy the full SHA 0fc2b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for de9f2d9 - Browse repository at this point
Copy the full SHA de9f2d9View commit details -
Merge branch '0332_release' of https://github.com/cdeline/bifacial_ra…
…diance into 0332_release
Configuration menu - View commit details
-
Copy full SHA for 54dbf52 - Browse repository at this point
Copy the full SHA 54dbf52View commit details -
Configuration menu - View commit details
-
Copy full SHA for e44e059 - Browse repository at this point
Copy the full SHA e44e059View commit details
Commits on Apr 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f8e4ec7 - Browse repository at this point
Copy the full SHA f8e4ec7View commit details
Commits on Apr 16, 2020
-
GUI: add timeIndexSimulation control. replace timestampRangeSimulatio…
…n with timeIndexSimulation in all .ini files. FIXES NREL#236
Configuration menu - View commit details
-
Copy full SHA for 311d5e4 - Browse repository at this point
Copy the full SHA 311d5e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b0b958 - Browse repository at this point
Copy the full SHA 3b0b958View commit details -
backwards compatibility load.py to accept timestampRangeSimulation ke…
…y from old .ini file
Configuration menu - View commit details
-
Copy full SHA for 958c600 - Browse repository at this point
Copy the full SHA 958c600View commit details -
release notes 0.3.3.2. Pytest checks timestampRangeSimulation backwar…
…d compatibility in .ini
Configuration menu - View commit details
-
Copy full SHA for d48f675 - Browse repository at this point
Copy the full SHA d48f675View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a7ba6c - Browse repository at this point
Copy the full SHA 5a7ba6cView commit details -
index documentation fix to tutorial URL NREL#232
Addresses issue NREL#232, wrong URL to Tutorial on the Index page of Documentation.
Configuration menu - View commit details
-
Copy full SHA for 30e2fc5 - Browse repository at this point
Copy the full SHA 30e2fc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f05e154 - Browse repository at this point
Copy the full SHA f05e154View commit details