Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commercial local docker runs #124

Merged
merged 8 commits into from
Jan 10, 2020
Merged

Conversation

asparke2
Copy link
Member

Fixes Local Docker for commercial runs.

Pull Request Description

Fixes Local Docker for commercial runs, which was previously broken.
Also fixes associated tests and many of the style and missing imports on rHorsey/enable-com branch.

Checklist

  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)

The methods in postprocessing.py still don't look like they'll work, although I've fixed some of the missing imports when I could figure out what the intent was.

@asparke2
Copy link
Member Author

Now with 50% less EOL goofs! Sorry about that guys!

@rHorsey
Copy link
Contributor

rHorsey commented Jan 10, 2020

One question, otherwise lgtm! Thanks @asparke2

Copy link
Contributor

@rHorsey rHorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

buildstockbatch/base.py Outdated Show resolved Hide resolved
@rHorsey rHorsey merged commit f3e88d0 into rHorsey/enable-com Jan 10, 2020
@rHorsey rHorsey deleted the fix_com_docker_4 branch January 13, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants